Hi,
I have completed the work on this bug by successfully building
it.Everythingworked fine.
So, i am sending the diff.
*Bug Id:* 6598117
*Synopsis:* code cleanup in vn_createat()
**
*Description:* Following code in vnode.c:vn_createat() is difficult to read:
offset = vap->va_size > vattr.va_size ?
vattr.va_size : vap->va_size;
length = vap->va_size > vattr.va_size ?
vap->va_size - vattr.va_size :
vattr.va_size - vap->va_size;
and would benefit if it is changed to:
offset = MIN(vap->va_size, vattr.va_size);
length = MAX(vap->va_size, vattr.va_size) - (size_t)offset;
oss-bite-size
*Category:* kernel:fs
*Diff:*
bash-3.00# diff -u vnode.c.orig vnode.c
--- vnode.c.orig Thu Dec 27 16:55:19 2007
+++ vnode.c Thu Dec 27 17:05:35 2007
@@ -1253,11 +1253,9 @@
u_offset_t offset;
ssize_t length;
- offset = vap->va_size > vattr.va_size ?
- vattr.va_size : vap->va_size;
- length = vap->va_size > vattr.va_size ?
- vap->va_size - vattr.va_size :
- vattr.va_size - vap->va_size;
+ offset = MIN(vap->va_size , vattr.va_size);
+ length = MAX(vap->va_size , vattr.va_size) -
(size_t)offset;
if (nbl_conflict(vp, NBL_WRITE, offset,
length, 0)) {
error = EACCES;
*SCA Number*: *OS0186 *
**
Thanks and Regards
Rejeesh Nath
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080113/591e4c72/attachment.html>
