Hey John Sorry for the late reply, again - I don't really have much time for Revelation these days :(
Anyway, I've committed a modified version of your patch in r568. I've stripped away much of the key handling stuff, since I don't want to add lots of custom UI and infrastructure just for a single file format. If I did this for all the various file formats, the UI and code would become a bloated mess. The downside of this is that a new LUKS file is created every time you save, overwriting any extra keys and stuff. You solved this by preserving the header between loads and saves, but that doesn't really fit with how datahandlers are currently implemented. A possible compromise could be to supply the export_data() method with a copy of the existing file data if an existing file is found - that way, you could extract the header from there. Also, the old file format is still the default, so you will need to use import/export to open LUKS files. I'll consider using LUKS as a default crypto backend when (if?) I implement the new file format. It would be great if you could have a look at it, do a bit of testing, and suggest any improvements before I do a release. Thanks again! On Sat, 2006-10-28 at 17:43 -0500, John Lenz wrote: > If you are doing a release soon, I would like to include LUKS support. > I have updated my patch to the latest svn code (revision 564). I have > been using this patch for months now with my own personal passwords.... > it works great. > > There are a few points in the GUI that could be changed, like assuming a > default of 5000 iterations (and maybe allowing to change in the settings > somewhere), or other GUI stuff like the choice of wording. I'll let you > work that out, I don't have much preference. > > http://www.cs.wisc.edu/~lenz/luks/rvl.diff > http://www.cs.wisc.edu/~lenz/luks/ > > For now you need to copy AfSplitter.py, luks.py, and PBKDFv2.py into the > datahandler install directory > (/usr/local/lib/python2.4/site-packages/revelation/datahandler/ on my > computer). > > (PS, I can use the decrypt.py on my site to read the contents of the > save file produced by revelation, and have also successfully used the > linux kernel to read the data!) > > John > > -- Erik Grinaker <[EMAIL PROTECTED]> http://erikg.codepoet.no/ "We act as though comfort and luxury were the chief requirements of life, when all that we need to make us happy is something to be enthusiastic about." -- Albert Einstein
