Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 888 by ted.dunning: LANGUAGE setting can confuse post-review due  
to assumption of English output from svn.
http://code.google.com/p/reviewboard/issues/detail?id=888


What steps will reproduce the problem?
1. export LANGUAGE=zh_CN:zh
2. export LC_ALL=zh_CN.utf-8
3. run svn info to observe messages in chinese
4. run post-review
5. svn output not parsed correctly due to localization of svn.

What is the expected output? What do you see instead?

Expect to see normal function.  Instead see a stack trace that indicates
that post-review is unable to determine the SCM settings.

What operating system are you using? What browser?
Chinese capable cygwin installation or linux.

Please provide any additional information below.

I think that it should be possible to have post-review set the correct
locale variables to en_US internally so that it gets the right output from
svn info.

Note that it can be kind of difficult to get a non-chinese machine to
produce the problematic messages from svn.  Don't mark this as NOTABUG
unless you succeed at getting non-English messages out of svn.  Changing
LANG and LC_ALL on a chinese machine sufficed to make the messages change
and the problem go away, however, so I am pretty sure that this is the  
problem.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to