Comment #2 on issue 1173 by erichuss: Binary files aren't listed in the
diff?
http://code.google.com/p/reviewboard/issues/detail?id=1173
I looked at this briefly. The diff fragment URL is telling it to remove
the entry.
From a URL like this: /r/10594/diff/1/fragment/113257/?index=1&1254766381
I got the following HTML code:
</table>
<script type="text/javascript">
$(document).ready(function() {
$("li.change_file_1").remove();
});
</script>
from the bottom of diff_file_fragment.html. Also, as a side issue, the
</table>
probably shouldn't be there. It looks like it's trying to explicitly
remove changes
that don't have change_chunks, presumably for the interfilediff case where
you don't
want to show files that have no interdiff changes. If that is correct,
maybe the
check for "if file.changed_chunks" should also be checking "if not
file.interfilediff"?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
