Comment #9 on issue 46 by bernard3000: 80-column indicator in diff view
http://code.google.com/p/reviewboard/issues/detail?id=46

If anyone comes to implement something, I would like it be changeable to 120 (we have
widescreen monitors now) :)

For me, I think just putting a div line on top would be sufficient -- even if lines are "wrapped" (essentially ignore the wrapped portion, and do not show the line if
the wrapping occurs "before" the 80 column mark).

Would that work for others?

Implementation: This could be done via javascript if the option is available. The javascript could decide to show the line or not "on-the-fly" (depending if that column is available without the wrapping (measure the size of "80 columns" in pixels
with a "hidden div" with 80 letters of the same monospaced font).

That way, the main document could stay unchanged if just the user settings is
available somehow (external .js or additional ajax call).

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to