Comment #6 on issue 1637 by paul.dubois: Review Board + perforce can not
upload diff
http://code.google.com/p/reviewboard/issues/detail?id=1637
Perforce, new reviewboard install, similar issue when using post-review. I
won't post the error data; it looks identical.
Strangely, the diff printed by "post-review -n" looks like it was generated
with p4 rather than diff -urNp. Here's the output of "post-review -n":
[C:\dfp-cust-b]post-review -n 349518
--- //dfp/Main/Common/Code/Python/dfp4.py
//dfp/Main/Common/Code/Python/dfp4.py#16
+++ //dfp/Main/Common/Code/Python/dfp4.py 2010-06-30 19:27:45
@@ -26,6 +26,7 @@ from P4 import P4Exception, P4Error
RAISE_ALL = 2
RAISE_ERROR = 1
RAISE_NONE = 0
+RAISE_A_RUCKUS = -1
# ----------------------------------------------------------------------
# DF wrapper around P4API wrapper
And here's what I get when running "diff" by hand (following
what "post-review -d" says it's doing):
[C:\dfp-cust-b]p4 print -o tmpa -q //dfp/main/common/code/python/dfp4.py#16
[C:\dfp-cust-b]diff -urNp c:\dfp-cust-b\tmpa
c:\dfp-cust-b\Common\Code\Python\dfp4.py
--- c:\dfp-cust-b\tmpa 2010-06-30 19:32:18.755014300 -0700
+++ c:\dfp-cust-b\Common\Code\Python\dfp4.py 2010-06-30
19:27:45.074381800 -0700
@@ -26,6 +26,7 @@ from P4 import P4Exception, P4Error
RAISE_ALL = 2
RAISE_ERROR = 1
RAISE_NONE = 0
+RAISE_A_RUCKUS = -1
# ----------------------------------------------------------------------
# DF wrapper around P4API wrapper
I tried uploading the output of "post-review -n" by hand, via the "Upload
Diff" button. The upload dialog box gave me the same error:
"One or more fields had errors"
"[Errno 2] No such file or directory"
I tried uploading the output of diff -urNp by hand and got different errors:
"One or more fields had errors"
"need more than 1 value to unpack"
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
