Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 1737 by kevin.go...@googlemail.com: Exception is thrown when
adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.5RC1
What's the URL of the page containing the problem?
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
What steps will reproduce the problem?
1. Add new repository: Hosting service "GitHub (private)"
2. Fill out all data
3. Hit "Save"
What is the expected output? What do you see instead?
Expected: repository gets added.
Actual: 500 page.
What operating system are you using? What browser?
OS X 10.6.4
Chrome 5.0, Firefox 3.6.8 (error happens in both)
Please provide any additional information below.
Error log dump is below:
ERROR:root:Exception thrown for user admin at
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
'tool'
Traceback (most recent call last):
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/core/handlers/base.py",
line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py",
line 512, in root
return self.model_page(request, *url.split('/', 2))
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/views/decorators/cache.py",
line 69, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py",
line 531, in model_page
return admin_obj(request, rest_of_url)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py",
line 1190, in __call__
return self.add_view(request)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py",
line 21, in _wrapper
return decorator(bound_func)(*args, **kwargs)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py",
line 76, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py",
line 17, in bound_func
return func(self, *args2, **kwargs2)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/db/transaction.py",
line 299, in _commit_on_success
res = func(*args, **kw)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py",
line 777, in add_view
if form.is_valid():
File "/home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py",
line 577, in is_valid
return (super(RepositoryForm, self).is_valid() and
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py",
line 121, in is_valid
return self.is_bound and not bool(self.errors)
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py",
line 112, in _get_errors
self.full_clean()
File "/home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py",
line 499, in full_clean
return super(RepositoryForm, self).full_clean()
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py",
line 268, in full_clean
self._clean_form()
File "/home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py",
line 296, in _clean_form
self.cleaned_data = self.clean()
File "/home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py",
line 515, in clean
self._clean_hosting_info()
File "/home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py",
line 447, in _clean_hosting_info
tool_name = self.cleaned_data['tool'].name
KeyError: 'tool'
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
