Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1862 by scottl...@gmail.com: reviewboard running patch against empty files
http://code.google.com/p/reviewboard/issues/detail?id=1862

What is the problem?
Reviewboard is running patch against empty file(s) causing forked process to sleep waiting for input.

What version are you running?
Stable 1.5

What's the URL of the page containing the problem?
Not sure, most likely review page with diff.

What steps will reproduce the problem?
1. touch /tmp/1-new /tmp/1
2. patch -o /tmp/1-new /tmp/1

What operating system are you using? What browser?
Linux 2.6, RHEL5.4 x86_64

Please provide any additional information below.
$ ps ax | grep [p]atch
12701 ? S 0:00 patch -o /tmp/reviewboard.tTK8b4/tmpd9XDhV-new /tmp/reviewboard.tTK8b4/tmpd9XDhV 12702 ? S 0:00 patch -o /tmp/reviewboard.FgJfUi/tmpc03lfo-new /tmp/reviewboard.FgJfUi/tmpc03lfo 12703 ? S 0:00 patch -o /tmp/reviewboard.u2QOpe/tmpO6NOTd-new /tmp/reviewboard.u2QOpe/tmpO6NOTd 13496 ? S 0:00 patch -o /tmp/reviewboard.g2wQDt/tmpHeiBNY-new /tmp/reviewboard.g2wQDt/tmpHeiBNY 13497 ? S 0:00 patch -o /tmp/reviewboard.E_I1If/tmpuB2hxE-new /tmp/reviewboard.E_I1If/tmpuB2hxE 15142 ? S 0:00 patch -o /tmp/reviewboard.al3iUL/tmpIUo9GD-new /tmp/reviewboard.al3iUL/tmpIUo9GD 15143 ? S 0:00 patch -o /tmp/reviewboard.8vqdLL/tmpZBiuIY-new /tmp/reviewboard.8vqdLL/tmpZBiuIY 15144 ? S 0:00 patch -o /tmp/reviewboard._aEgqp/tmp2T2Mq8-new /tmp/reviewboard._aEgqp/tmp2T2Mq8 15145 ? S 0:00 patch -o /tmp/reviewboard.CP_FrE/tmpCJNp1z-new /tmp/reviewboard.CP_FrE/tmpCJNp1z

$ ls -la /tmp/reviewboard.tTK8b4/tmpd9XDhV-new /tmp/reviewboard.tTK8b4/tmpd9XDhV
-rw------- 1 $user $group 0 Oct 22 05:13 /tmp/reviewboard.tTK8b4/tmpd9XDhV
-rw------- 1 $user $group 0 Oct 22 18:44 /tmp/reviewboard.tTK8b4/tmpd9XDhV-new

$ gdb /usr/bin/patch --pid=12701
...
(gdb) bt
#0  0x00000032296c5f00 in __read_nocancel () from /lib64/libc.so.6
#1  0x000000322966b853 in _IO_file_xsgetn_internal () from /lib64/libc.so.6
#2  0x0000003229661c82 in fread () from /lib64/libc.so.6
#3  0x000000000040baef in ?? ()
#4  0x00000000004062e4 in ?? ()
#5  0x000000322961d994 in __libc_start_main () from /lib64/libc.so.6
#6  0x0000000000401c49 in ?? ()
#7  0x00007fff7bb4f968 in ?? ()
#8  0x0000000000000000 in ?? ()

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to