Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 1896 by Karrde712: Omitting the git repo path throws 500 error
http://code.google.com/p/reviewboard/issues/detail?id=1896
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
ReviewBoard 1.5.1
What's the URL of the page containing the problem?
New repo creation
What steps will reproduce the problem?
1. Create a custom git repo
2. Fill in the raw file URL and remote path
3. Click save
What is the expected output? What do you see instead?
I expect to see a warning that the repo path is mandatory, but not
specified. Instead, I get a 500 error, and this appears in the Apache
error_log:
[Tue Nov 23 11:46:28 2010] [error] ERROR:root:Exception thrown for user
admin at
http://publictest4.fedoraproject.org/reviewboard/admin/db/scmtools/repository/1/
[Tue Nov 23 11:46:28 2010] [error]
[Tue Nov 23 11:46:28 2010] [error] 'path'
[Tue Nov 23 11:46:28 2010] [error] Traceback (most recent call last):
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py", line
99, in get_response
[Tue Nov 23 11:46:28 2010] [error] response = callback(request,
*callback_args, **callback_kwargs)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/contrib/admin/options.py",
line 225, in wrapper
[Tue Nov 23 11:46:28 2010] [error] return
self.admin_site.admin_view(view)(*args, **kwargs)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/views/decorators/cache.py",
line 44, in _wrapped_view_func
[Tue Nov 23 11:46:28 2010] [error] response = view_func(request, *args,
**kwargs)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/contrib/admin/sites.py", line
186, in inner
[Tue Nov 23 11:46:28 2010] [error] return view(request, *args, **kwargs)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/db/transaction.py", line 240,
in _commit_on_success
[Tue Nov 23 11:46:28 2010] [error] res = func(*args, **kw)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/contrib/admin/options.py",
line 827, in change_view
[Tue Nov 23 11:46:28 2010] [error] if form.is_valid():
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py", line
578, in is_valid
[Tue Nov 23 11:46:28 2010] [error] return (super(RepositoryForm,
self).is_valid() and
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/forms/forms.py", line 119, in
is_valid
[Tue Nov 23 11:46:28 2010] [error] return self.is_bound and not
bool(self.errors)
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/forms/forms.py", line 110, in
_get_errors
[Tue Nov 23 11:46:28 2010] [error] self.full_clean()
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py", line
500, in full_clean
[Tue Nov 23 11:46:28 2010] [error] return super(RepositoryForm,
self).full_clean()
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/django/forms/forms.py", line 249, in
full_clean
[Tue Nov 23 11:46:28 2010] [error] self.cleaned_data = self.clean()
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py", line
520, in clean
[Tue Nov 23 11:46:28 2010] [error] self._verify_repository_path()
[Tue Nov 23 11:46:28 2010] [error]
File "/usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py", line
643, in _verify_repository_path
[Tue Nov 23 11:46:28 2010] [error] path = self.cleaned_data['path']
[Tue Nov 23 11:46:28 2010] [error] KeyError: 'path'
What operating system are you using? What browser?
Red Hat Enterprise Linux 5.5
Firefox 3.6.12 and Chromium 8.0.560.0 both experience this.
Please provide any additional information below.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
