Comment #10 on issue 929 by sed...@gmail.com: reviewboard should not alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
All "git diff format support" tickets were closed as duplicate of this ticket. I don't know why but the need for git diff format support has more ramifications than just "sharing diffs":
- It can describe move/rename operations which saves the reviewer's time to understand the "three pages of removed line block" and "three pages of added line block" were actually a single rename.
- Mercurial Queues REQUIRE git-diff format to work correctly. It's recommended to be set it in the .hgrc. That prevents developer from being able to generate unified diff format and requires editing .hgrc file over and over for each specific goal.
- When binary files are present, MQ switches to git format which cannot be turned off in newer Mercurial versions (namely 2.2.1).
-- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
