Comment #1 on issue 2573 by michael....@unister.de: Diffs not displayed when first diff on page fails to apply
http://code.google.com/p/reviewboard/issues/detail?id=2573

This still happens in version 1.6.10. It seems to come from reviewboard/diffviewer/views.py in method view_diff where a preload of the first file is tried. If the patch doesn't apply cleanly at this first file we seem to get an Exception instead of the usual Error and consequently the whole page isn't loaded. One thing which seems to (crudely) remedy this is the following patch which simply deactivates the preload. I hope you can do something about this. Thanks!

Attachments:
        views.py.diff  2.4 KB

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to