Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2747 by abrou...@yelp.com: Dirty markup in /dashboard.
http://code.google.com/p/reviewboard/issues/detail?id=2747
Running 1.6.12, on OS X 10.7.4 and Chrome 22.
-----------
Steps to repro:
1. Go to "/dashboard/"
2. Edit your columns and check "My comments" if that's not active already.
3. Inspect the markup of on of the icon
-----------
Expected: clean markup
Actual: there are some nasty <django.utils.functional.__proxy__ object at
0x1a31c50> in the title and alt attributes (see attached screenshot)
-----------
Probable cause: string interpolation in django
py 2.6.7 >>> print u'%s' % _("foo")
foo
py 2.6.7 >>> print '%s' % _("foo")
<django.utils.functional.__proxy__ object at 0x1a31c50>
From the Django doc
(https://docs.djangoproject.com/en/1.3/topics/i18n/internationalization/#lazy-translation):
# This is fine: putting a unicode proxy into a unicode string.
u"Hello %s" % ugettext_lazy("people")
# This will not work, since you cannot insert a unicode object
# into a bytestring (nor can you insert our unicode proxy there)
"Hello %s" % ugettext_lazy("people")
Cheers,
Arnaud.
Attachments:
bad-markup-in-RB.png 20.7 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
