Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium
New issue 3280 by ke...@keithmoyer.com: Next/Previous keyboard shortcuts
should honor "Hide Whitespace Changes"
http://code.google.com/p/reviewboard/issues/detail?id=3280
What version are you running?
1.7.12
What's the URL of the page this enhancement relates to, if any?
site/r/###/diff
Describe the enhancement and the motivation for it.
There exists an option to hide whitespace changes, which is really helpful
when reviewing changes where someone also did a bunch of cleanup. However,
the hotkeys (n, p) still hit every single change.
The hotkeys should either skip the "dimmed" changes ) or another set of
hotkeys should be introduced.
What operating system are you using? What browser?
Windows 7, Firefox.
Please provide any additional information below.
diffViewerPageView.js, _getNextAnchor is what ultimately gets called to
find the next place to jump to. Checking for !$anchor.hasClass('dimmed')
in the if statement would take care of this if it's okay to always jump
over them when they're dimmed (which seems reasonable to me).
That or a new ANCHOR_VISIBLE_CHUNK anchor type should be added with new or
repurposed (some of the existing next/prev hotkeys could hit them all while
others could skip hidden changes) hotkeys matched to the new anchor type.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
