Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3506 by anhi...@cisco.com: Extension review request fields
http://code.google.com/p/reviewboard/issues/detail?id=3506
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
e625b89
What's the URL of the page containing the problem?
/r/N/ for any review request N
What steps will reproduce the problem?
1. Create and enable an extension with extra fields extending
BaseEditableField and/or BaseTextAreaField with is_required = True
2. Create a new review request and observe the fields displayed correctly
(with a * indicating that the field is required)
3. Publish the draft with empty required fields, and submit the review
request with fields still empty
What is the expected output? What do you see instead?
Something somewhere should prevent either draft publication or review
request submission when required fields are empty. However, currently the
draft publication and review request submission complete successfully with
empty required fields.
What operating system are you using? What browser?
N/A
Please provide any additional information below.
Since the ReviewRequestApprovalHook only applies to API checks, and doesn't
give any means to prevent submission on missing fields, some sort of
validation process should be baked into the custom fields.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
