Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3732 by ondr...@salsitasoft.com: rbt post is generating diff
against origin/master when on a local feature branch
https://code.google.com/p/reviewboard/issues/detail?id=3732
What version are you running?
Review Board 2.0.11 + RBTools 0.7
What's the URL of the page containing the problem?
RBTools are affected, so no URL really...
What steps will reproduce the problem?
1. Create a local git branch, doesn't matter where.
2. Checkout the branch, create a few commits.
2. Run rbt post HASH where HASH points to a local commit on that branch,
can be even rbt post HEAD I guess.
3. Watch rbt generating diff against origin/master.
What is the expected output? What do you see instead?
I would expect rbt to only take the commit specified by HASH and post the
diff. Why is it even computing anything?
The debug error output follows:
→ rbt post --debug de05642e1f0544aa59dd068eebe71476927d1bff
RBTools 0.7
Python 2.7.9 (default, Dec 11 2014, 04:42:00)
[GCC 4.9.2]
Running on Linux-3.17.6-1-ARCH-x86_64-with-glibc2.2.5
Home = DELETED
Current directory = DELETED
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: 'DELETED' is not a working copy
---
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.DELETED.merge
Command exited with rc 1: ['git', 'config', '--get',
u'branch.DELETED.merge']
---
Running: git config --get branch.DELETED.remote
Command exited with rc 1: ['git', 'config', '--get',
u'branch.DELETED.remote']
---
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:DELETED.git, Base path: ,
Supports changesets: False
Running: git config --get reviewboard.url
Making HTTP GET request to DELETED
Cached response for HTTP GET DELETED/api/ expired and was not modified
Running: git rev-parse DELETED
Running: git rev-parse DELETED^
Running: git merge-base DELETED origin/master
Running: git diff --no-color --full-index --ignore-submodules -M
--no-ext-diff DELETED..DELETED
Running: git diff --no-color --full-index --ignore-submodules -M
--no-ext-diff DELETED..DELETED
Making HTTP GET request to DELETED/api/validation/
Cached response for HTTP GET DELETED/api/validation/ expired and was
not modified
Making HTTP GET request to DELETED/api/validation/diffs/
Cached response for HTTP GET DELETED/api/validation/diffs/ expired and
was modified
Making HTTP POST request to DELETED/api/validation/diffs/
Got HTTP error: 413: <html>
<head><title>413 Request Entity Too Large</title></head>
<body bgcolor="white">
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nDELETED</center>
</body>
</html>
Traceback (most recent call last):
File "/usr/bin/rbt", line 9, in <module>
load_entry_point('RBTools==0.7', 'console_scripts', 'rbt')()
File "/usr/lib/python2.7/site-packages/rbtools/commands/main.py", line
133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py",
line 538, in run_from_argv
exit_code = self.main(*args) or 0
File "/usr/lib/python2.7/site-packages/rbtools/commands/post.py", line
662, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff
HTTP 413
What operating system are you using? What browser?
Not important.
Please provide any additional information below.
rbt starts to behave properly once the feature branch is pushed to the
origin.
Was trying to fix the behaviour using one of the flags, but started to get
things like
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
