Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3824 by kevin.be...@gmail.com: Git hooks not working
https://code.google.com/p/reviewboard/issues/detail?id=3824

When using the git hooks provided in RBTools/contrib/tools, I've got a Python TypeError.

This bug affect RBTools v0.7.2
The version 0.6 works fine.

Example of a "git push" with the two server-side hooks:

$> git push
Counting objects: 9, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (6/6), 572 bytes | 0 bytes/s, done.
Total 6 (delta 3), reused 0 (delta 0)
remote: ['92838c18206430eadad27792c744458e1391b8e2 d0f234ec84f84973b1e3d2992d67af45f8f373ca refs/heads/master\n']
remote: Traceback (most recent call last):
remote:   File "hooks/pre-receive", line 80, in <module>
remote:     main()
remote:   File "hooks/pre-receive", line 49, in main
remote: review_id_to_commits = get_review_id_to_commits_map(lines, compiled_regex) remote: File "/usr/local/lib/python2.7/dist-packages/RBTools-0.7.2-py2.7.egg/rbtools/hooks/git.py", line 78, in get_review_id_to_commits_map
remote:     commit_hashes = get_commit_hashes(old_rev, new_rev)
remote: File "/usr/local/lib/python2.7/dist-packages/RBTools-0.7.2-py2.7.egg/rbtools/hooks/git.py", line 20, in get_commit_hashes
remote:     return execute(git_command, split_lines=True)
remote: TypeError: execute() got an unexpected keyword argument 'split_lines'
To ssh://git@192.168.1.105/my_repo
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@192.168.1.105/my_repo'


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to