Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3864 by seide.al...@gmail.com: "rbt post
//depot/path/...@r1,@r2" throws an exception in 0.7.2 and no review
request gets created
https://code.google.com/p/reviewboard/issues/detail?id=3864
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools 0.7.2
RB 1.7.28 and 2.0.15
What's the URL of the page containing the problem?
NA
What steps will reproduce the problem?
1.
2.
3.
$ rbt --version
RBTools 0.6.3
$ rbt post //depot/Jam/MAIN/src/...@813,@823
Review request #11 posted.
http://localhost/r/11/
http://localhost/r/11/diff/
I discarded that review and then ran the same exact command against the same
repo using RBTools 0.7.2. I had to add the debug option to get any useful
output:
$ rbt --version
RBTools 0.7.2
$ rbt post -d //depot/Jam/MAIN/src/...@813,@823
<snip>
+Test submitting a review with a shelve and no ship its.
---
Writing "//depot/Jam/MAIN/src/RELNOTES#77" to "/tmp/tmpQNewPu"
Running: p4 print -o /tmp/tmpQNewPu -q //depot/Jam/MAIN/src/RELNOTES#77
Writing "//depot/Jam/MAIN/src/RELNOTES#78" to "/tmp/tmpUJo72G"
Running: p4 print -o /tmp/tmpUJo72G -q //depot/Jam/MAIN/src/RELNOTES#78
Running: diff -urNp /tmp/tmpQNewPu /tmp/tmpUJo72G
Command exited with rc 1: [u'diff',
u'-urNp', '/tmp/tmpQNewPu', '/tmp/tmpUJo72G']
--- /tmp/tmpQNewPu 2015-05-05 17:54:57.889010010 -0700
+++ /tmp/tmpUJo72G 2015-05-05 17:54:57.893009847 -0700
@@ -548,3 +548,4 @@ Release notes for Jam 2.0.
A poorly set $(JAMSHELL) is likely to result in silent
failure.
+Test creating with 2 jobs.
---
Making HTTP GET request to http://localhost/api/validation/diffs/
Cached response for HTTP GET http://localhost/api/validation/diffs/
expired and was modified
Making HTTP POST request to http://localhost/api/validation/diffs/
Traceback (most recent call last):
File "/home/sallan/envs/rbtools-0.7.2/bin/rbt", line 9, in <module>
load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
File "/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/main.py",
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File "/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/__init__.py",
line 555, in run_from_argv
exit_code = self.main(*args) or 0
File "/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py",
line 714, in main
self.check_guess_fields()
File "/home/sallan/envs/rbtools-0.7.2/local/lib/python2.7/site-packages/RBTools-0.7.2-py2.7.egg/rbtools/commands/post.py",
line 553, in check_guess_fields
assert self.revisions
AssertionError
When I ran it under a debugger, I found that it was trying to run
p4 change //depot/Jam/MAIN/src/...@813,@823
What is the expected output? What do you see instead?
A new review request
What operating system are you using? What browser?
CentOS 6 and Ubuntu
Please provide any additional information below.
Chris correctly assessed the problem:
This looks like a bug with the commit message guessing feature and Perforce
revision ranges. Can you try running the same command with '-g no' ?
That does in fact get past the error.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
