Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3877 by buck.a...@gmail.com: "Ship it" counts on the dashboard include multiple "ship it"s from one person
https://code.google.com/p/reviewboard/issues/detail?id=3877

What version are you running?
2.0.13. I've also reproduced the issue on ReviewBoard's demo instance (currently, 2.5 beta 2)

What's the URL of the page containing the problem?
http://demo.reviewboard.org/dashboard/

What steps will reproduce the problem?
1. Create a new empty review.
2. Have a single user account give the review two "ship it!"s
3. View the dashboard.
4. Note that the dashboard shows a "ship it" count of two despite only one person having reviewed the code.

What is the expected output? What do you see instead?
The dashboard should show the number of people who have given the review a ship it instead of the total number of ship its received.

What operating system are you using? What browser?
Linux. Firefox.

Please provide any additional information below.
A review might have multiple ship its from one person if the diff is updated significantly and someone that has already given the review a ship it gives it another after reading the updated diff. Other reviewers browsing their dashboard might choose to skip the review if they see that it has multiple ship its, even though there was only one person that reviewed it and gave it a ship it.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to