Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3924 by csipak.a...@ardinsys.eu: shortcuts to file diffs do not
work in Firefox and Chrome
https://code.google.com/p/reviewboard/issues/detail?id=3924
What version are you running?
2.0.15
What's the URL of the page containing the problem?
/r/{review_request_id}/diff/{diff_revision}/
(Diff Viewer)
What steps will reproduce the problem?
Notes:
- We use Review Board in post-commit fashion exclusively.
- We use SVN repos.
Case 1 (reviewed commit spans ~5+ files)
1. Create and publish a post commit review request based on 5-20 file
changes. (One-line changes are not preferable, the whole diff should span
multiple screens in the diff viewer.)
2. Open the review request and then the diff viewer.
3. Wait until the diffs get populated into the diff summary (spinners get
replaced by colored indicators).
4. Click on one of the changed files in the list, preferably one close to
the bottom of the list.
5. The window jumps to the selected file, then the diffs get repopulated,
then the window scrolls to somewhere to the 5-20% of the page, close to the
top, but not to the file selected.
6. Retry 4.
7. Now the window is scrolled to the selected file.
Case 2 (reviewed commit spans 20+ files)
1. Create and publish a post commit review request based on more than 20
file changes.
2. Open the review request and then the diff viewer.
3. Wait until the diffs get populated into the diff summary (spinners get
replaced by colored indicators).
4. Since there are more than 20 files affected, the diff summary is broken
to 20-file pages. Navigate away from the first page to any other page.
5. Click on any file from the page summary, wait for the diff summaries to
be loaded (spinners get replaced by colored indicators).
6. Click on any file from the page summary.
7. The window jumps to the selected file, then to page 1, then the diffs
get repopulated, then the window scrolls to somewhere to the 5-20% of the
page, close to the top, but not to the file selected.
8. Lather, rinse, repeat from 4.
What is the expected output? What do you see instead?
As stated above: instead of just jumping to the file selected from the diff
summary, the window jumps to the selected file, then to page 1, then the
diffs get repopulated, then the window scrolls to somewhere to the 5-20% of
the page, close to the top, but not to the file selected.
What operating system are you using? What browser?
The bug is reprodicible with:
Windows 7 + Firefox 39.0
Windows 7 + Chrome 43.0
Ubuntu 14.04 + Firefox
The bug is NOT reproducible with:
Windows 7 + Internet Explorer 11.0
Please provide any additional information below.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
