------------------------------------------------------------------------------ To reply, visit https://hellosplat.com/s/beanbag/tickets/4512/ ------------------------------------------------------------------------------
New ticket #4512 by chipx86 For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect ------------------------------------------------------------------------------ Localization is incorrect in the Admin UI Settings forms ============================================================================== # What version are you running? 2.0+ # What's the URL of the page containing the problem? /admin/settings/* # What is the problem? The forms in `reviewboard.admin.forms` use `ugettext` (as `_(...)`) for the form fields, which means they're localized at application initialization time rather than at page render time. They should be using `ugettext_lazy` as `_(...)`. The code inside of functions that use `ugettext` should continue to do so, since those happen at render time. So: 1. We should update the `_` alias to be for `ugettext_lazy` instead of `ugettext`, for anything used as members of the forms. 2. We should import `ugettext` and call that specifically for anything happening within a function. ------------------------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
