------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4624/
------------------------------------------------------------------------------

New ticket #4624 by tusharpm
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * cmake.diff
   <https://hellosplat.com/s/beanbag/attachments/1268/>

 * CMakeLists.txt
   <https://hellosplat.com/s/beanbag/attachments/1269/>



------------------------------------------------------------------------------
Syntax highlight missing for CMakeLists.txt in diff viewer
==============================================================================

# What version are you running?
- 2.5.3 in production (private instance - access restricted).
- Issue also seen on [demo.reviewboard.org](demo.reviewboard.org) 3.0 RC2.

# What's the URL of the page containing the problem?
No public permalink available.
Can use attachment to see issue on 
[demo.reviewboard.org](http://demo.reviewboard.org/r/1021/diff/1#index_header) 
[Note: may get purged at midnight].

# What steps will reproduce the problem?
1. Create new review request with (attached) `cmake.diff`.
2. Go to Diff viewer.

# What is the expected output? What do you see instead?
The diff viewer does not highlight the added CMakeLists.txt.
The expected behavior is to see highlighted syntax.

# What operating system are you using? What browser?
The private instance is running on Ubuntu 14.04.5 LTS.
The issue is visible on all major browsers: Apple Safari, Google Chrome, 
Mozilla Firefox, Opera browser. [Haven't tried Microsoft Internet Explorer or 
Edge.]

# Please provide any additional information below.
- The file attachment view shows syntax highlighted properly.
- The code most relevant to the issue is in 
[f4a7da4ec0f854bf9ae618a3a28d922f704cc90c](https://github.com/reviewboard/reviewboard/commit/f4a7da4ec0f854bf9ae618a3a28d922f704cc90c).

------------------------------------------------------------------------------

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to