------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/5012/
------------------------------------------------------------------------------

New update by HeroicAlbeit
For Beanbag, Inc. > Review Board > Ticket #5012


Reply:

    Thanks for the detailed information!
    
    Our default Nginx setup forwards over the requested hostname to Review 
Board, and Review Board then uses that hostname to construct URLs for the APIs. 
In this case, Review Board is seeing its host as being `<private instance ip>`, 
which probably makes sense in this case, though we'll need to verify.
    
    Since your Nginx isn't serving up as `<public server name>`, the host it's 
sending along to Django isn't going to be `<public server name>`, so one of two 
options will need to be explored:
    
    1. Changing `proxy_set_header Host $host` to `proxy_set_header Host 
your_public_server_name`.
    2. If API Gateway forwards on a host using `X-Forwarded-Host` in the 
request, then you can set `USE_X_FORWARDED_HOST = True` in Review Board's 
`/site/conf/settings_local.py`. (This would need to be tested for sure).
    
    The latter is off by default for security reasons, and should only be 
turned on if in this exact situation.
    
    We'll need to do some work on our end to add documentation and comments 
throughout these files to cover these scenarios.
    
    Can you see if one or both of those work, and let me know? We'll then get 
this documented on our end.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20231107215013.23425.24134%40ip-10-1-54-209.ec2.internal.

Reply via email to