Glad to hear :) Thanks for reporting back on that.
We have some further improvements we're hoping to make for large diffsets
that should improve speed there too. Not sure when we're getting to that
(I'm juggling two large changes right now), but hopefully before too long.
Christian
--
Christian Hammond - [EMAIL PROTECTED]
VMware, Inc.
On Tue, Nov 4, 2008 at 10:41 AM, mary <[EMAIL PROTECTED]> wrote:
>
> The plan to dump my SQL, do a fresh install, and then insert the old
> data worked just fine with a couple tweaks of the db data. I had a
> large reviewboard DB and the new install has been working fine for a
> week now.
>
> I'd like to say that I absolutely had Django 1.0 and tip of Django
> Evolution and the "unique" issue still existed, but I had a somewhat
> older ReviewBoard and MySQL (mysql i think was the actual issue,
> django evolution doesn't support it well yet.)
>
> Anyway, thanks all. I'm happy to now be on a newer ReviewBoard. Some
> of the perf issues we had prior with large diffs look to be partially
> resolved.
>
> On Oct 28, 10:13 am, "Christian Hammond" <[EMAIL PROTECTED]> wrote:
> > The "unique" issue should have been fixed long ago, provided you have a
> > modern Django Evolution. Are you definitely running the latest SVN
> release,
> > and you don't have something really old installed somewhere?
> >
> > Christian
> >
> > --
> > Christian Hammond - [EMAIL PROTECTED]
> > VMware, Inc.
> >
> >
> >
> > On Tue, Oct 28, 2008 at 8:47 AM, plumpy <[EMAIL PROTECTED]> wrote:
> >
> > > That is pretty much exactly what I did last week... Dumped my mysql
> > > database without the table definitions, created a clean database,
> > > loaded it with './manage.py syncdb', and then loaded my old data into
> > > that database (after massaging a few things, like deleting the
> > > permissions table and a few others). It's been working fine for me for
> > > a few days, although we just finished a software release so our code
> > > review activity has slowed down a lot.
> >
> > > On Oct 27, 11:20 pm, mary <[EMAIL PROTECTED]> wrote:
> > > > After experimenting, I believe I can work around the db evolution
> bugs
> > > > by installing a fresh install of reviewboard, creating a new
> database,
> > > > and then bascially inserting my old database into a new db.
> >
> > > > This has required a few tweaks to the old data, but otherwise
> > > > everything appears to be working okay on my test system. (Namely, i
> > > > had to delete everything from the default table, then insert my old
> > > > data accounting for a new column addition to reviewrequestdraft
> table.
> > > > I also had to insert a siteconfig which wasn't in my old table.)
> > > > Hopefully I'm not overlooking anything else.
> >
> > > > If, in the future, any major database changes are made this won't
> work
> > > > for me, so i hope django evolution fixes the mysql issues i ran
> > > > into.
> >
> > > > On Oct 24, 3:09 pm, mary <[EMAIL PROTECTED]> wrote:
> >
> > > > > Here are some more details on this error in case someone can
> help...
> >
> > > > > When I run "./manage.py evolve --sql --hint" I see that the bad SQL
> > > > > its trying to run is:
> > > > > -- Evolve application scmtools
> > > > > DROP INDEX id ON `scmtools_tool`;
> >
> > > > > If I try to run this command directly on reviewboard database
> (MySQL
> > > > > v5.0.45) I get this error:
> > > > > mysql> DROP INDEX id ON scmtools_tool;
> > > > > ERROR 1091 (42000): Can't DROP 'id'; check that column/key
> exists
> >
> > > > > The column and index does exist however:
> > > > > mysql> show index from scmtools_tool;
> > > > > +---------------+------------+------------+--------------
> > > > > +-------------+-----------+-------------+----------+
> -------+------
> > > > > +------------+---------+
> > > > > | Table | Non_unique | Key_name | Seq_in_index |
> > > > > Column_name | Collation | Cardinality | Sub_part | Packed | Null |
> > > > > Index_type | Comment |
> > > > >
> +---------------+------------+------------+--------------+-------------
> > > > > +-----------+-------------+----------+--------+------+------------
> > > > > +---------+
> > > > > | scmtools_tool | 0 | PRIMARY | 1 | id
> > > > > | A | 6 | NULL | NULL | | BTREE
> > > > > | |
> > > > > | scmtools_tool | 0 | name | 1 | name
> > > > > | A | 6 | NULL | NULL | | BTREE
> > > > > | |
> > > > > | scmtools_tool | 0 | class_name | 1 |
> class_name
> > > > > | A | 6 | NULL | NULL | | BTREE
> > > > > | |
> > > > >
> +---------------+------------+------------+--------------+-------------
> > > > > +-----------+-------------+----------+--------+------+------------
> > > > > +---------+
> > > > > 3 rows in set (0.00 sec)
> >
> > > > > Any ideas?
> >
> > > > > On Oct 24, 2:39 pm, mary <[EMAIL PROTECTED]> wrote:
> >
> > > > > > I've installed the official Django 1.0 Release and am having the
> same
> > > > > > problem. The ChangeField mutations just aren't working.
> >
> > > > > > For example,
> > > > > > This Mutations:
> > > > > > ChangeField('Tool', 'id', initial=None, unique=False)
> > > > > > Appears to give this error:
> > > > > > The following are the changes that could not be resolved:
> > > > > > In model scmtools.Tool:
> > > > > > In field 'id':
> > > > > > Property 'unique' has changed
> >
> > > > > > I'm totally unable to upgrade my reviewboard from a few months
> back!
> > > > > > Can anyone with django evolution experience help me?
> >
> > > > > > On Oct 3, 5:01 pm, mary <[EMAIL PROTECTED]> wrote:
> >
> > > > > > > I have the Django SVN version but at revision level -r8960
> which
> > > was
> > > > > > > at their 1.0 release time. Is that not sufficient? I don't see
> why
> > > i'd
> > > > > > > need the official release if I have the SVN version at that
> > > revision
> > > > > > > level. i'll give it a try none the less... sigh.
> >
> > > > > > > On Oct 3, 4:00 pm, "Christian Hammond" <[EMAIL PROTECTED]>
> > > wrote:
> >
> > > > > > > > According to our buildbot, it is working properly with the
> latest
> > > Django
> > > > > > > > Evolution.
> >
> > > > > > > > I guess the other thing to check is that you are in fact
> running
> > > Django 1.0
> > > > > > > > and not somehow using the SVN release.
> >
> > > > > > > > Christian
> >
> > > > > > > > --
> > > > > > > > Christian Hammond - [EMAIL PROTECTED]
> > > > > > > > VMware, Inc.
> >
> > > > > > > > On Fri, Oct 3, 2008 at 3:40 PM,mary<[EMAIL PROTECTED]>
> wrote:
> >
> > > > > > > > > I'm definitely hitting the latest django-evolution. I've
> > > verified this
> > > > > > > > > by running the manage.py script with python -v and verifing
> the
> > > import
> > > > > > > > > path and also I have experimented to get various revisions
> of
> > > django-
> > > > > > > > > evolution. Nothing works.
> >
> > > > > > > > > Has anyone confirmed evolution of ReviewBoard database
> works
> > > when
> > > > > > > > > using MySQL and changing field unique to false?
> >
> > > > > > > > > On Oct 3, 1:47 pm, "Christian Hammond" <
> [EMAIL PROTECTED]>
> > > wrote:
> > > > > > > > > > Make sure you don't have a stale system-installed version
> in
> > > your python
> > > > > > > > > > path. I'll look into it to make sure it didn't break
> again,
> > > though at
> > > > > > > > > first
> > > > > > > > > > glance it doesn't appear to be.
> >
> > > > > > > > > > Christian
> >
> > > > > > > > > > --
> > > > > > > > > > Christian Hammond - [EMAIL PROTECTED]
> > > > > > > > > > VMware, Inc.
> >
> > > > > > > > > > On Fri, Oct 3, 2008 at 10:16 AM,mary<[EMAIL PROTECTED]>
> > > wrote:
> >
> > > > > > > > > > > Hi,
> >
> > > > > > > > > > > In attempting to upgrade our ReviewBoard server to the
> > > latest and
> > > > > > > > > > > greatest I'm running into errors running db evolutions
> > > 'Property
> > > > > > > > > > > 'unique' has changed'. (see errors below)
> >
> > > > > > > > > > > In previous posts it suggests this problem has been
> fixed
> > > however, I
> > > > > > > > > > > have updated Django to revision (#8960 = r1.0),
> > > Django-Evolution to
> > > > > > > > > > > the trunk/head, and reviewboard to the trunk/head (as
> of
> > > 10/2/08).
> >
> > > > > > > > > > > What am I missing?
> > > > > > > > > > > Running CentOS 5.0, Apache 2.2.3, and MySQL 5.0.
> >
> > > > > > > > > > > [reviewboard]$ sudo ./manage.py syncdb
> > > > > > > > > > > Project signature has changed - an evolution is
> required
> > > > > > > > > > > Project signature has changed - an evolution is
> required
> > > > > > > > > > > Installing json fixture 'initial_data' from
> > > '/usr/lib/python2.4/site-
> > > > > > > > > > > packages/reviewboard/scmtools/fixtures'.
> > > > > > > > > > > Installed 6 object(s) from 1 fixture(s)
> > > > > > > > > > > [reviewboard]$ sudo ./manage.py evolve --execute
> > > > > > > > > > > The stored evolutions do not completely resolve all
> model
> > > changes.
> > > > > > > > > > > Run `./manage.py evolve --hint` to see a suggestion for
> the
> > > changes
> > > > > > > > > > > required.
> >
> > > > > > > > > > > The following are the changes that could not be
> resolved:
> > > > > > > > > > > In model reviews.Comment:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.Group:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.Screenshot:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.Review:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.ReviewRequestDraft:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.ReviewRequest:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.DefaultReviewer:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model reviews.ScreenshotComment:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model sessions.Session:
> > > > > > > > > > > In field 'session_key':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model admin.LogEntry:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model sites.Site:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model auth.Message:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model auth.Group:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model auth.User:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model auth.Permission:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model scmtools.Tool:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model scmtools.Repository:
> > > > > > > > > > > In field 'id':
> > > > > > > > > > > Property 'unique' has changed
> > > > > > > > > > > In model contenttypes.ContentType:
> > > > > > > > > > > In field 'id':
> >
> > ...
> >
> > read more ยป- Hide quoted text -
> >
> > - Show quoted text -
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---
