Hi Christian, thanks so much! I'll update our server first thing in the morning.
How else do you get a trophy? That was so neat to see that the 1111st ID got a trophy :) Thanks, Martin On Jan 16, 5:43 pm, Christian Hammond <chip...@chipx86.com> wrote: > Hi Martin. > > There's a patch up to fix this, which I'm going to commit today. If someone > can upgrade the server today or tomorrow, once it goes in, then this problem > will be taken care of. Sorry about the inconvenience :( > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > On Fri, Jan 16, 2009 at 5:56 AM, Martin <mkoeb...@gmail.com> wrote: > > > Hi, > > a colleague of mine recently created the 1111st code review request > > which gave him a nice looking trophy! Really neat easter egg. I just > > updated my reviewboard to svn trunk and that trophy seems to cause > > some trouble now. We no longer can view that reviewrequest. > > > Please help :) > > > Environment: > > > Request Method: GET > > Request URL:http://codereview.ykf.navtech.corp/reviewboard/r/1111/ > > Django Version: 1.0.2 final > > Python Version: 2.4.3 > > Installed Applications: > > ['django.contrib.admin', > > 'django.contrib.auth', > > 'django.contrib.contenttypes', > > 'django.contrib.markup', > > 'django.contrib.sites', > > 'django.contrib.sessions', > > 'djblets.datagrid', > > 'djblets.feedview', > > 'djblets.siteconfig', > > 'djblets.util', > > 'djblets.webapi', > > 'reviewboard.accounts', > > 'reviewboard.admin', > > 'reviewboard.changedescs', > > 'reviewboard.diffviewer', > > 'reviewboard.iphone', > > 'reviewboard.reports', > > 'reviewboard.reviews', > > 'reviewboard.scmtools', > > 'reviewboard.webapi', > > 'django_evolution'] > > Installed Middleware: > > ('django.middleware.common.CommonMiddleware', > > 'django.middleware.doc.XViewMiddleware', > > 'django.middleware.locale.LocaleMiddleware', > > 'django.contrib.sessions.middleware.SessionMiddleware', > > 'django.contrib.auth.middleware.AuthenticationMiddleware', > > 'djblets.siteconfig.middleware.SettingsMiddleware', > > 'reviewboard.admin.middleware.LoadSettingsMiddleware', > > 'djblets.log.middleware.LoggingMiddleware', > > 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware') > > > Template error: > > In template /var/www/reviewboard/templates/reviews/trophy_box.html, > > error at line 9 > > Caught an exception while rendering: u'review_request.id' > > 1 : {% load djblets_deco %} > > > 2 : {% load djblets_utils %} > > > 3 : {% load i18n %} > > > 4 : {% load reviewtags %} > > > 5 : > > > 6 : {% ifneatnumber review_request.id %} > > > 7 : {% box "yay" %} > > > 8 : <img src="{{MEDIA_URL}}rb/images/{% if milestone %}trophy{% > > else %}fish-trophy{% endif %}.png" width="32" height="48" border="0" > > alt="" /> > > > 9 : <h1> {% blocktrans with review_request.submitter| > > user_displayname as submitter %} {{submitter}} got review request # > > {{review_request.id}}!{% endblocktrans %}</h1> > > > 10 : {% endbox %} > > > 11 : {% endifneatnumber %} > > > 12 : > > > 13 : > > > Traceback: > > File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py" > > in get_response > > 86. response = callback(request, *callback_args, > > **callback_kwargs) > > File "/var/www/reviewboard/accounts/decorators.py" in _check > > 27. return view_func(*args, **kwargs) > > File "/usr/lib/python2.4/site-packages/django/views/decorators/ > > cache.py" in _cache_controlled > > 30. response = viewfunc(request, *args, **kw) > > File "/var/www/reviewboard/reviews/views.py" in review_detail > > 175. return render_to_response(template_name, RequestContext > > (request, { > > File "/usr/lib/python2.4/site-packages/django/shortcuts/__init__.py" > > in render_to_response > > 18. return HttpResponse(loader.render_to_string(*args, > > **kwargs), **httpresponse_kwargs) > > File "/usr/lib/python2.4/site-packages/django/template/loader.py" in > > render_to_string > > 107. return t.render(context_instance) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 176. return self.nodelist.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 71. result = node.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py" > > in render > > 97. return compiled_parent.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 176. return self.nodelist.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 71. result = node.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py" > > in render > > 24. result = self.nodelist.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 71. result = node.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/loader_tags.py" > > in render > > 111. return self.template.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 176. return self.nodelist.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 71. result = node.render(context) > > File "/var/www/reviewboard/djblets/util/decorators.py" in render > > 150. return self.tag_func(context, self.nodelist, *args) > > File "/var/www/reviewboard/reviews/templatetags/reviewtags.py" in > > ifneatnumber > > 84. s = nodelist.render(context) > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 71. result = node.render(context) > > File "/var/www/reviewboard/djblets/util/decorators.py" in render > > 150. return self.tag_func(context, self.nodelist, *args) > > File "/var/www/reviewboard/djblets/util/templatetags/djblets_deco.py" > > in box > > 42. return render_to_string('deco/box.html', { > > File "/usr/lib/python2.4/site-packages/django/template/__init__.py" in > > render > > 768. bits.append(self.render_node(node, context)) > > File "/usr/lib/python2.4/site-packages/django/template/debug.py" in > > render_node > > 81. raise wrapped > > > Exception Type: TemplateSyntaxError at /reviewboard/r/1111/ > > Exception Value: Caught an exception while rendering: > > u'review_request.id' > > > Original Traceback (most recent call last): > > File "/usr/lib/python2.4/site-packages/django/template/debug.py", > > line 71, in render_node > > result = node.render(context) > > File "/usr/lib/python2.4/site-packages/django/templatetags/i18n.py", > > line 85, in render > > data = dict([(v, force_unicode(context[v])) for v in vars]) > > File "/usr/lib/python2.4/site-packages/django/template/context.py", > > line 43, in __getitem__ > > raise KeyError(key) > > KeyError: u'review_request.id' > > > Thanks! > > > Martin --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
