So it's really going to depend on the sizes of the individual files themselves. If a file is by itself large enough to cause a couple meg diff to be generated, there's nothing we can do really do, since that boils down to too large a file to show in the browser.
In your page 3 example, how big are the files and the diffs in particular? The page itself loads quick enough, right? It's just the diff fragments? Which ones are you finding takes a long time and how big are those changes? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Mar 16, 2009 at 5:32 PM, mary <ciaom...@gmail.com> wrote: > > On really large diffs, performance is very slow and can crash the > browser. > > We've picked up the recent 3/13/09 nightly which has helped enormously > (A BIG THANKS!) but that said, we're still finding pages that take 3+ > minutes to load. > > For example.... we have one review in particular that has File Changes > spread over 6 ReviewBoard pages. Page 3 takes on average 3+ minutes to > load. It also readily crashes my browser - pegging my CPU and I have > to kill the session. (URL= https://reviewboard/r/2808/diff/?page=3). > This is in FireFox 3.0.7. Under IE the page doesn't load without > running into script errors. Unfortunately, these large ReviewBoard > diffs are a typical use case at our company (typically when large > merges are done) and breaking things across more than 10 reviews jsut > isn't plausible. I should mention that not only are the diff fragments > themselves large for these use cases but the number of reviewers and > comments gets to be very large too. We're maxing out what ReviewBoard > can handle on all fronts. > > Can further investigation be done into these performance issues for > us? I will supply further information as I collect it. > > Thanks, > Mary > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
