Yeah, it's definitely due to spaces in the filenames. Eris Huss did some work that should lead to a fix for this, I believe, but someone encountering this problem needs to find where it's breaking and update the code to make this work.
Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 14, 2009 at 6:37 AM, roshan pius <roshanpiustho...@gmail.com>wrote: > > The complete output of post-review -d : > > >>> p4 info > >>> repository info: Path: xxxxxxxx:1666, Base path: None, Supports > changesets: True > >>> Generating diff for changenum 10020 > >>> p4 describe -s 10020 > >>> Processing edit of //<branch>/host/src/Assisted File > Transfer/AftMain.cpp > >>> Writing "//<branch>/host/src/Assisted File Transfer/AftMain.cpp#1" to > "c:\docume~1\rpius\locals~1\temp\tmptkche3" > >>> p4 print -q "//<branch>/host/src/Assisted File Transfer/AftMain.cpp#1" > >>> p4 where "//<branch>/host/src/Assisted File Transfer/AftMain.cpp" > >>> diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 > Transfer/AftMain.cpp > >>> Processing edit of //<branch>/host/src/Assisted File > Transfer/ConfigReader.cpp > >>> Writing "//<branch>/host/src/Assisted File Transfer/ConfigReader.cpp#1" > to "c:\docume~1\rpius\locals~1\temp\tmptkche3" > >>> p4 print -q "//<branch>/host/src/Assisted File > Transfer/ConfigReader.cpp#1" > >>> p4 where "//<branch>/host/src/Assisted File Transfer/ConfigReader.cpp" > >>> diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 > Transfer/ConfigReader.cpp > >>> Processing edit of //<branch>/host/src/Assisted File Transfer/StdAfx.h > >>> Writing "//<branch>/host/src/Assisted File Transfer/StdAfx.h#1" to > "c:\docume~1\rpius\locals~1\temp\tmptkche3" > >>> p4 print -q "//<branch>/host/src/Assisted File Transfer/StdAfx.h#1" > >>> p4 where "//<branch>/host/src/Assisted File Transfer/StdAfx.h" > >>> diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 Transfer/StdAfx.h > >>> Looking for 'xxx.xxx.xxx.xxx /' cookie in C:\Documents and > Settings\<username>\Local Settings\Application Data\.post-review-cookies.txt > >>> Loaded valid cookie -- no login required > >>> Attempting to create review request for 10020 > >>> HTTP POSTing to http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/new/: > {'repository_path': 'xxxxxxxx:1666', 'changenum': '10020'} > >>> Review request already exists. Updating it... > >>> HTTP POSTing to > http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/update_from_changenum/: > {} > >>> Review request created > >>> Uploading diff, size: 37349 > >>> HTTP POSTing to > http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/diff/new/: {} > Review request #186 posted. > > http://xxx.xxx.xxx.xxx:80/r/186 > > Thanks, > Roshan Pius > > On Tue, Apr 14, 2009 at 6:15 PM, Raghu <raghu...@gmail.com> wrote: > > > > Can you provide the complete output of post-review -d? My first guess > > would be that it is due to a space in the file path. > > > > -Raghu > > > > On Apr 13, 10:25 am, roshanpius <roshanpiustho...@gmail.com> wrote: > >> Hi , > >> > >> I've been using post-review tool for posting reviews for Review Board > >> for a Perforce Repository. I've integrated the post-review tool into > >> P4V which is the GUI P4 Client For Windows. This worked fine till now. > >> > >> But now i've created a new workspace and tried using post-review, but > >> the diff didn't fetch the file from my hard disk. It was fetching the > >> correct file from Repository, but not finding the correct edited file > >> on my Workspace. > >> > >> I ran post-review with -d flag to get the debug logs and i noticed > >> that the path on the Workspace that the diff was trying to fetch was > >> completely wrong: > >> > >> diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/ > >> ConfigReader.cpp > >> > >> It should have been: > >> > >> diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan- > >> unicode\host\src\Assisted File Transfer/ConfigReader.cpp > >> > >> I'm using post-review with the following arguments in the P4V Client: > >> > >> python C:\Python26\post-review.py %c --p4-client $c --p4-port $p > >> > >> Do i need to change something in the post-review Configuration for the > >> new workspace ? > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
