Sorry, I was wrong. You should see the Parent Diff field when choosing
Upload Diff, but not New Review Request. This field was never added to
templates/new_review_request.html. If you add it, it should work. It should
be the "parent_diff_path" field. Copy/paste the "diff_path" and see if it
just works.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, Jun 16, 2009 at 1:49 AM, Sebastien Douche <sdou...@gmail.com> wrote:

>
> On Mon, Jun 15, 2009 at 20:35, Christian Hammond<chip...@chipx86.com>
> wrote:
> >> I see: "Added support for parent diffs for Mercurial. Patch by Colin
> >> Caughie." Why haven't you change initial screen (create a Hg review
> >> request)? It's not possible to create a review request with parent
> >> path.
> >
> > Pretty much because it wasn't in the patch that added this support. If
> you
> > want to whip up a patch to do this (modify get_fields in scmtools/hg.py)
> > then I'll get it in for 1.0.
>
> Hi Christian,
> surely I'm too stupid to do that, because I can't found the necessary
> change: parent_diff_path / base_diff_path / ... don't work :(.
>
> --
> Sebastien Douche <sdou...@gmail.com>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to