Thanks. For example:
r1 committed by Mike r2 committed by Mike r3 committed by Bob r4 committed by Fred r5 committed by Mike I would want to review r1, r2 and r5 in one single review, which I don't think would work in your example. On Feb 4, 6:21 pm, Matthew Woehlke <mw_tr...@users.sourceforge.net> wrote: > On 2010-02-04 10:13, Stodge wrote: > > > Am I right in thinking that a review can only refer to a single diff > > (where a diff may contain multiple changesets/revisions)? And > > uploading a new diff will replace the existing one with a newer > > version? > > Yes. > > > If my understanding is right, we need to be able to group multiple > > revisions on one review. For example, we use Trac and multiple commits > > are made per ticket. I want to write a Trac plugin that will add the > > diff for each commit to a review (wherever that review may reside, > > ReviewBoard or elsewhere etc). Is this possible with RB? > > You could upload the diff of the first revision, publish it, upload the > cumulative diff of the first and second revisions, publish it, upload... > and so on. That will let reviewers view (vcs:r2) by looking at the > changes between (rb:r1 == vcs:r2) and (rb:r2 == vcs:r1+r2), which might > be close to what you want. > > I use this frequently when I have vcs:r1 == a bunch of whitespace > changes and vcs:r2 == interesting changes. Note that you can assign the > review initially to a dummy user to avoid spamming everyone when you > incrementally upload+publish diffs. > > -- > Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
