Hello, We are using Review Board with P4. We had one P4 repository set-up on our Review Board server and it was working great. Today I added a second P4 Repository and now when we do a post review from the original repository we get an error: STATUS: 09:47:56 True STATUS: 09:47:56 Traceback (most recent call last): STATUS: 09:47:56 File "\\mtl-cpl-af018\MyTools\review.py", line 101, in <module> STATUS: 09:47:56 main(sys.argv[1:]) STATUS: 09:47:56 File "\\mtl-cpl-af018\MyTools\review.py", line 94, in main STATUS: 09:47:56 libpostreview.main() STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib \libpostreview.py", line 2885, in main STATUS: 09:47:56 diff, parent_diff = tool.diff(args) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib \libpostreview.py", line 1519, in diff STATUS: 09:47:56 return self._changenum_diff(changenum) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib \libpostreview.py", line 1792, in _changenum_diff STATUS: 09:47:56 new_file = self._depot_to_local(depot_path) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib \libpostreview.py", line 1939, in _depot_to_local STATUS: 09:47:56 where_output = self._run_p4(['where', depot_path]) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib \libpostreview.py", line 1643, in _run_p4 STATUS: 09:47:56 p = subprocess.Popen(command, stdout=subprocess.PIPE) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib\subprocess.py", line 586, in __init__ STATUS: 09:47:56 errread, errwrite) = self._get_handles(stdin, stdout, stderr) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib\subprocess.py", line 681, in _get_handles STATUS: 09:47:56 p2cread = self._make_inheritable(p2cread) STATUS: 09:47:56 File "\\mtl-cpl-af018\python25\lib\subprocess.py", line 722, in _make_inheritable STATUS: 09:47:56 DUPLICATE_SAME_ACCESS) STATUS: 09:47:56 TypeError: an integer is required STATUS: 09:47:56 Exception exceptions.AttributeError: '_shutdown' in <module 'threading' from '\\mtl-cpl-af018\python25\lib\threading.pyc'> ignored
I tried using the --repository-url parameter but then it says I need to use --revision-range or --diff-filename option. When looking in the help of Review Board there are only examples for -- revision-range if doing post-committing reviews. We only use pre- committing reviews (ie: diff files from depot). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
