Thanks for the clarification. We'll look into it on our end in the pre-commit integration.
On Wednesday, May 30, 2012 11:55:44 AM UTC-7, Christian Hammond wrote: > > Review Board actively tries to stay out of this sort of policy. We don't > have anything for preventing self-reviews, and likely won't. In the end, we > have no control whether a person is allowed to submit code. That's a > company policy sort of thing. So, it doesn't make a lot of sense to prevent > a user from reviewing their own code or marking Ship It. > > If you have some form of pre-commit hook that checks if code has been > reviewed, it should also be able to filter out the Ship Its from the author > quite easily. > > Christian > > On Wed, May 30, 2012 at 11:24 AM, Rob Fagen wrote: > >> Doesn't look like this was ever answered. We've got the same situation >> that we want to prevent self-review (we have another mechanism for checking >> in without review). >> >> >> On Thursday, January 5, 2012 6:39:50 AM UTC-8, Igor Berger wrote: >>> >>> Agreed. But I want to make sure at least 1 other person looks at my >>> changes. >>> >>> It's good that I can comment on a review I submitted. >>> But I want to enforce that someone else has to click Ship It. >>> >> > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
