If they have any sort of front-end viewer to the repositories, and if there's any way in that viewer to view/download the raw file (and the path for that includes a "blob SHA1", which is the type of SHA1 that's in a diff -- should be testable by doing your own diff against something in the repository and comparing), then things will work.
Without having access to that server, I can't investigate it, though. You'll have to poke around. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Feb 20, 2013, at 12:34 PM, sma...@origamisoftware.com wrote: > OK, so I won't be able to use Reviewboard because I don't have access to > machine the repo is running on. Ah well. > > I am not sure which frontend it is using. It is branded > source.the_company.com which 'the_company' is some big company. Everyone in > this large company is encouraged to use it. > > It is entirely possibly that "the_company" rolled their own front end > although it is a bit more polished than a lot of the other internal apps so I > am guessing they started somewhere. I looked at the HTML for some clues as to > wether this was a customized framework or their own but came up short. > Featurewise it is like a poorman's github. You can't directly commit code > using it. It provides a clone URL (just like github). It has a dashboard. > You can view commits. > > Sorry, I can't be more specific. I just don't know. > > Spencer > > > > On Wednesday, February 20, 2013 3:06:01 PM UTC-5, David Trowbridge wrote: > What frontend is it using? > > > -David > > > On Wed, Feb 20, 2013 at 10:16 AM, <sma...@origamisoftware.com> wrote: > Hi, > > Thanks for the info. Ironically, > ssh://x...@source.mycompany.com/base/git/project is already hosted on a > website that like, but neither gitweb or cgit so introducing a third layer > here seems like less than a good idea to me. > > Does cgit needs to be installed on the machine where the remote repo lives? > (I don't have access to that machine) > > I did try installing on the machine where I am running reviewboard, but when > I got the second installation instruction (git submodule init), I got this > error: > > Submodule 'git' (git://git.kernel.org/pub/scm/git/git.git) registered for > path 'git' > > -S. > > > > On Tuesday, February 19, 2013 4:41:46 PM UTC-5, David Trowbridge wrote: > The issue here is that git does not support getting raw files directly from a > remote repository. You'll need to use a frontend that supports this (such as > cgit or gitweb) and use the raw-file URL. See > http://www.reviewboard.org/docs/manual/1.7/admin/configuration/repositories/#raw-file-urls > for more info. > > > -David > > > On Tue, Feb 19, 2013 at 1:37 PM, <sma...@origamisoftware.com> wrote: > Hi, > > This looks a bit of FAQ, but I tried working through the solutions I found > posted without success. > > Basically, I can't create reviews using git and git diff. I've tried both the > command line line version of git-diff and using post-review. > > > I got this: > > Error uploading diff > > The generated diff file was empty. This usually means no files were > modified in this change. > > Try running with --output-diff and --debug for more information. > > Your review request still exists, but the diff is not attached. > > generates this: > > So I did this > > post-review --parent=master --username=smarks --password=**** > > which generates: > > post-review --parent=master --username=smarks --password=*** --output-diff > --debug > >>> RBTools 0.4.3 > >>> Python 2.7.3 (default, Aug 1 2012, 05:16:07) > [GCC 4.6.3] > >>> Running on Linux-3.2.0-37-generic-pae-i686-with-Ubuntu-12.04-precise > >>> Home = /home/sam > >>> Current Directory = /home/sam/project > >>> Checking the repository type. Errors shown below are mostly harmless. > DEBUG:root:Checking for a Bazaar repository... > DEBUG:root:Checking for a CVS repository... > DEBUG:root:Checking for a ClearCase repository... > DEBUG:root:Checking for a Git repository... > DEBUG:root:Running: git rev-parse --git-dir > DEBUG:root:Running: git config core.bare > DEBUG:root:Running: git rev-parse --show-toplevel > DEBUG:root:Running: git symbolic-ref -q HEAD > DEBUG:root:Running: git config --get branch.master.merge > DEBUG:root:Running: git config --get branch.master.remote > DEBUG:root:Running: git config --get remote.origin.url > DEBUG:root:repository info: Path: > ssh://x...@source.mycompany.com/base/git/project, Base path: , Supports > changesets: False > >>> Finished checking the repository type. > DEBUG:root:Running: git config --get reviewboard.url > >>> HTTP GETting api/info/ > DEBUG:root:Running: git merge-base origin/master refs/heads/master > DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff > --ignore-submodules --no-renames master -M > DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff > --ignore-submodules --no-renames > e3c8c6323531ba0dfd7790c49e984622cbac885f..master -M > diff --git a/doc/ReadMe.txt b/doc/ReadMe.txt > index > 079eb6ba65d3a26ff88e7ef0908f4e4f0d61ab7a..9daa1db1b2eb7ace6e5f3b6086b9572ea90c2aac > 100644 > --- a/doc/ReadMe.txt > +++ b/doc/ReadMe.txt > @@ -1,7 +1,9 @@ > Project documentation can go in this folder. > > -Please put some here > +Link to a the wiki would be OK or please put some here. > + > > -Link to a the wiki would be OK too > > Thanks... > + > + > > So there is a diff (which is not empty), but apparently it not getting pushed > up to review board correctly. > > > When I tried just using git diff > my.diff > Which contains: > diff --git a/doc/ReadMe.txt b/doc/ReadMe.txt > index 079eb6b..9daa1db 100644 > --- a/doc/ReadMe.txt > +++ b/doc/ReadMe.txt > @@ -1,7 +1,9 @@ > Project documentation can go in this folder. > > -Please put some here > +Link to a the wiki would be OK or please put some here. > + > > -Link to a the wiki would be OK too > > Thanks... > + > + > > > and uploading my.diff to the server I get: > fatal: Not a git repository: 'None' > > There no logging entries for this error. > > My repository is configured like this: > > name = "foo" > hosting server= None (Custom repository) > Repository Type = Git > Path = ssh://x...@source.mycompany.com/base/git/project (which works with > git clone ssh://x...@source.mycompany.com/base/git/project from the command > line) > > All the other fields are empty. > > Thanks in advance for any help resolving this issue. > > S. > > > > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to reviewboard...@googlegroups.com > > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard...@googlegroups.com. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to reviewboard...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
