Hi Steve,

There's no special flag for this. We implemented this functionality pre-1.0 and 
it has never changed. The only way you ever see Close or Update is when you 
have superuser privileges or the Can Edit/Can Close privileges. I'm not aware 
of this ever regressing or changing throughout the history of Review Board.

Both the UI and the API for handling those commands check these privileges in 
order to show/allow the operations. There isn't a single point of failure here.

The only other way that this could be set is if somebody modified the code 
you're running at some point to hard-code these privileges.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Jun 14, 2013, at 2:18 PM, Steve <seide.al...@gmail.com> wrote:

> I do not have staff or superuser set for this account, nor any special mod 
> permissions.  And everyone here also sees the same 'Close' button on other 
> people's reviews.  So, something is configured.  I wonder if there's an old 
> database setting that we've been pulling along since the 1.0.x, 1.5 days 
> that's causing this.  Do you have some ideas on what db tables I can look in 
> for clues?
> 
> --Steve
> 
> 
> On Friday, June 14, 2013 2:09:49 PM UTC-7, Christian Hammond wrote:
> Hi Steve,
> 
> Are you set up as an admin on both servers? Or do you have the Can Close 
> privilege set?
> 
> If so, 1.7.x should behave the same as it did in 1.6.x (and certainly does in 
> our installs).
> 
> Christian
> 
> 
> On Jun 14, 2013, at 14:04, Steve <seide...@gmail.com> wrote:
> 
>> I'd like to back up and break this down into smaller, simpler questions.
>> 
>> When I go to my 1.6.9 RB server and browse to another user's review, I see 
>> these buttons along the top, right portion of the page:
>> 
>>         Download Diff    Review    Ship It!    View Diff
>> 
>> When I go to  both of my 1.7.6 servers and browse to another user's review, 
>> I see these buttons along the top, right portion of the page:
>> 
>>         Close    Update    Download Diff    Review    Ship It!    View Diff
>> 
>> I only see the 'Close' button in 1.6.9 when I'm viewing my own requests. 
>> 
>> So, is that an intentional change in RB 1.7, or is my site somehow 
>> misconfigured?
>> 
>> Thanks!
>> 
>> --Steve
>> 
>> 
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to reviewboard...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
> 
> 
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to