Hi Christian,
Thanks for the quick reply. 10.100.10.2 is the CVS server and
10.100.10.231 is the reviewboard server.
The following is in my .reviewboardrc file, of the directory I'm doing
the post-review from:
REVIEWBOARD_URL = "http://10.100.10.231/";
REPOSITORY_TYPE="cvs"
REPOSITORY = "cvsroot" #The name the matches the reviewboard's
repository name.
USERNAME = "user"
PASSWORD = "password"
DEBUG = 1
SUMMARY="Sample Summary"
DESCRIPTION="Sample Description"
The following is my output when running the post-review:
C:\Projects\projectxyz>post-review blob.cpp
>>> RBTools 0.5.1
>>> Python 2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit
(Intel)]
>>> Running on Windows-7-6.1.7601-SP1
>>> Home = C:\Users\...\AppData\Roaming
>>> Current Directory = C:\Projects\projectxyz
>>> Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a CVS repository...
DEBUG:root:repository info: Path: CVS-SERVER-DNS-NAME:/home/cvsroot/,
Base path: None
, Supports changesets: False
>>> Finished checking the repository type.
>>> HTTP GETting api/info/
DEBUG:root:Running: cvs diff -uN blob.cpp
DEBUG:root:Command exited with rc 1: ['cvs', 'diff', '-uN', 'blob.cpp']
Index: blob.cpp
===================================================================
RCS file: /home/cvsroot/path/on/cvs/server//blob.cpp,v
retrieving revision 1.3
diff -u -r1.3 blob.cpp
--- blob.cpp 28 Jun 2013 23:28:55 -0000 1.3
+++ blob.cpp 1 Jul 2013 19:56:57 -0000
@@ -31,7 +31,12 @@
__fastcall TformBlob::TformBlob(TComponent* Owner)
: TForm(Owner)
{
+<<<<<<< blob.cpp
+ // This is a test to see if I can get it into source control with review
board.
+ // test 2 after clean check in.
+=======
// jao: This is a test to see if I can get it into source control with r
eview board.
+>>>>>>> 1.3
}
//---------------------------------------------------------------------------
void __fastcall TformBlob::btnSelectFileClick(TObject *Sender)
---
>>> HTTP GETting api/
>>> HTTP GETting http://10.100.10.231/api/info/
>>> Using the new web API
>>> Attempting to create review request on cvsroot for None
>>> HTTP POSTing to http://10.100.10.231/api/review-requests/:
{'repository': 'c
vsroot'}
>>> Review request created
>>> Uploading diff, size: 762
>>> HTTP POSTing to http://10.100.10.231/api/review-requests/36/diffs/: {}
>>> Got API Error 105 (HTTP code 400): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u"cvs [checkout aborted]:
Absolute module
reference invalid: `/home/cvsroot/path/on/cvs/server/blob.cpp'\n"
]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors',
u'code'
: 105}}
Error uploading diff
Your review request still exists, but the diff is not attached.
C:\Projects\projectxyz>
My project's CVS folder has the following in the Root file:
:pserver:user:password@10.100.10.2:/home/cvsroot/
The CVS folder's Repository file looks like:
relative/path/from/cvsroot/to/Project/
The server log shows:
None - user - /api/review-requests/35/diffs/ - Error uploading new diff: cvs
[checkout aborted]: Absolute module reference invalid:
`/home/cvsroot/path/on/cvs/server/blob.cpp'
Traceback (most recent call last):
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/webapi/resources.py",
line 2040, in create
request.FILES.get('parent_diff_path'))
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/reviews/forms.py",
line 308, in create
history)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/diffviewer/forms.py",
line 88, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/diffviewer/forms.py",
line 189, in _process_files
self.request))):
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/models.py",
line 187, in get_file_exists
exists = self._get_file_exists_uncached(path, revision, request)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/models.py",
line 290, in _get_file_exists_uncached
exists = self.get_scmtool().file_exists(path, revision)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/core.py",
line 81, in file_exists
self.get_file(path, revision)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/cvs.py",
line 54, in get_file
return self.client.cat_file(path, revision)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/cvs.py",
line 271, in cat_file
return self._cat_specific_file(filename, revision)
File
"/usr/lib/python2.6/site-packages/ReviewBoard-1.7.11-py2.6.egg/reviewboard/scmtools/cvs.py",
line 322, in _cat_specific_file
raise SCMError(errmsg)
SCMError: cvs [checkout aborted]: Absolute module reference invalid:
`/home/cvsroot/path/on/cvs/server/blob.cpp'
Thanks,
James
On Tuesday, July 2, 2013 12:52:03 PM UTC-7, Christian Hammond wrote:
Hi James,
Can you show me the "Error uploading diff" error when using post-review
with --debug?
Christian
James Oravec wrote:
> Got past this issue. It was related to my connection string in my
CVS
> directory's "Root" file. I was modifying it, trying to get past a
> different error. The summary is my connection string was
incorrect, so
> when I did the "post-review --output-diff" it wasn't able to
connect,
> thus why it had the empty diff.
>
> I'm now back to working on my "Error uploading diff" issue.
>
> On Tuesday, July 2, 2013 9:38:40 AM UTC-7, James Oravec wrote:
>
> Hi Christian,
>
> Did you guys ever figure out the issue with this? I'm receiving the
> same errors both on the client and server side. Any help would be
> greatly appreciated.
>
> Thanks,
> James
>
>
>
> On Monday, September 26, 2011 4:59:39 PM UTC-7, Christian Hammond
wrote:
>
> Hi Matthew,
>
> So I've seen this issue mentioned before with Review Board, but
> also with CVS in general. It's possible it's us. Can you perhaps
> privately e-mail me with the Path and Mirror Path field info on
> your Repository entry?
>
> Here's a link to someone who's hit it with just plain ol' CVS
> and has some workaround (though it's not very detailed):
>
> http://devnet.jetbrains.net/thread/158342
<http://devnet.jetbrains.net/thread/158342>
> <http://devnet.jetbrains.net/thread/158342
<http://devnet.jetbrains.net/thread/158342>>
>
> Christian
>
> --
> Christian Hammond - chi...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Mon, Sep 26, 2011 at 4:26 PM, Matthew <matt...@gmail.com> wrote:
>
> I appreciate the quick help.
>
> After enabling logging and running the commands again I get
> the output
> below. I notice the absolute module reference points into
> the cvs
> repository. After checking in the repository, there is no
> "Version.java", although there is "Version.java,v". I don't
> know if
> it's significant that this repository is a new import of the
> WorldWind
> code for Review Board testing purposes, the only file that
> has ever
> been checked out is "Version.java", and it has never been
> checked back
> in.
>
> Matt (log follows)
>
> [lihm@rbvm3 WorldWind]$ more /var/www/myserver.com/logs/
<http://myserver.com/logs/>
> <http://myserver.com/logs/>
> reviewboard.log
> 2011-09-26 16:12:33,711 - DEBUG - DiffParser.parse:
> Beginning parse of
> diff, size = 2741
> 2011-09-26 16:12:33,712 - DEBUG - DiffParser.parse: Finished
> parsing
> diff.
> 2011-09-26 16:12:33,832 - ERROR - Error uploading new diff: cvs
> [checkout aborted]: Absolute module reference invalid:
> `/usr/local/c
> vsroot/WorldWind/src/gov/nasa/worldwind/Version.java'
> Traceback (most recent call last):
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/webapi/resources.py", line 1478, in create
> request.FILES.get('parent_diff_path'))
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/reviews/forms.py", line 286, in create
> history)
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/diffviewer/forms.py", line 62, in create
> files = list(self._process_files(
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/diffviewer/forms.py", line 144, in _process_files
> if (revision != PRE_CREATION and
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/scmtools/core.py", line 70, in file_exists
> self.get_file(path, revision)
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/scmtools/cvs.py", line 48, in get_file
> return self.client.cat_file(path, revision)
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/scmtools/cvs.py", line 248, in cat_file
> return self._cat_specific_file(filename, revision)
> File
> "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
> reviewboard/scmtools/cvs.py", line 299, in _cat_specific_file
> raise SCMError(errmsg)
> SCMError: cvs [checkout aborted]: Absolute module reference
> invalid: `/
> usr/local/cvsroot/WorldWind/src/gov/nasa/worldwind/Version.ja
> va'
>
>
>
> On Sep 26, 4:05 pm, Christian Hammond <chip...@chipx86.com>
> wrote:
> > Hi Matthew,
> >
> > It's entirely possible that that error is misleading.
> Looking at the code,
> > it's possible that the same error code could be generated
> when there's also
> > an unexpected error on Review Board's end.
> >
> > If you have access to the reviewboard server logs, look
> for a line starting
> > with "Error uploading new diff:"
> >
> > That might give a better idea as to what's going on. Let
> me know what it
> > says.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> >
> >
> >
> >
> >
> >
> > On Mon, Sep 26, 2011 at 3:57 PM, Matthew
> <matt....@gmail.com> wrote:
> > > The cvs command issued by post-review executes, but
> post-review
> > > doesn't seem to think there are any diffs to upload.
> I'll include the
> > > result of post-review --output-diff --debug at the end
> of this message
> >
> > > Although I have a software background it has been a
> long time since
> > > I've done any sort of sysadmin work, and I'm not
> familiar with cvs or
> > > python. So please use small words.
> >
> > > Any help would be appreciated.
> >
> > > Matt (post-review session below, had to change the
> server name, but
> > > everything else is copied from xterm)
> >
> > > [lihm@rbvm3 WorldWind]$ post-review --output-diff --debug
> > > >>> RBTools 0.3.3
> > > >>> Home = /home/lihm
> > > >>> svn info
> > > >>> repository info: Path:
> myserver.com:8080/usr/local/cvsroot
<http://myserver.com:8080/usr/local/cvsroot>
> <http://myserver.com:8080/usr/local/cvsroot
<http://myserver.com:8080/usr/local/cvsroot>>, Base path:
> > > None, Supports changesets: False
> > > >>> HTTP GETting api/
> > > >>> HTTP GETtinghttp://myserver.com/rbmain/api/info/
<http://myserver.com/rbmain/api/info/>
> <http://myserver.com/rbmain/api/info/
<http://myserver.com/rbmain/api/info/>>
> > > >>> Using the new web API
> > > >>> cvs diff -uN
> > > cvs diff: Diffing .
> > > cvs diff: Diffing src
> > > cvs diff: Diffing src/config
> > > cvs diff: Diffing src/gov
> > > cvs diff: Diffing src/gov/nasa
> > > cvs diff: Diffing src/gov/nasa/worldwind
> > > Index: src/gov/nasa/worldwind/Version.java
> > >
> ===================================================================
> > > RCS file:
> /usr/local/cvsroot/WorldWind/src/gov/nasa/worldwind/
> > > Version.java,v
> > > retrieving revision 1.1.1.1
> > > diff -u -r1.1.1.1 Version.java
> > > --- src/gov/nasa/worldwind/Version.java 7 Sep 2011 18:17:04
> > > -0000 1.1.1.1
> > > +++ src/gov/nasa/worldwind/Version.java 26 Sep 2011
> 22:34:40 -0000
> > > @@ -11,6 +11,8 @@
> > > * @version $Id: Version.java,v 1.1.1.1 2011/09/07
> 18:17:04 root Exp
> > > $
> > > */
> >
> > > +// MML 20110916 Review Board Test
> > > +
> > > public class Version
> > > {
> > > private static final String MAJOR_VALUE = "0";
> > > cvs diff: Diffing src/gov/nasa/worldwind/applications
> > > cvs diff: Diffing src/gov/nasa/worldwind/applications/sar
> > > cvs diff: Diffing src/gov/nasa/worldwind/avlist
> > > cvs diff: Diffing src/gov/nasa/worldwind/awt
> > > cvs diff: Diffing src/gov/nasa/worldwind/cache
> > > cvs diff: Diffing src/gov/nasa/worldwind/event
> > > cvs diff: Diffing src/gov/nasa/worldwind/examples
> > > cvs diff: Diffing src/gov/nasa/worldwind/examples/applet
> > > cvs diff: Diffing src/gov/nasa/worldwind/exception
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/csv
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/dds
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/georss
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/gpx
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/nitfs
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/nmea
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/rpf
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/tiff
> > > cvs diff: Diffing src/gov/nasa/worldwind/formats/wvt
> > > cvs diff: Diffing src/gov/nasa/worldwind/geom
> > > cvs diff: Diffing src/gov/nasa/worldwind/geom/coords
> > > cvs diff: Diffing src/gov/nasa/worldwind/globes
> > > cvs diff: Diffing src/gov/nasa/worldwind/issues
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/Earth
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/Mars
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/Moon
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/placename
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/rpf
> > > cvs diff: Diffing src/gov/nasa/worldwind/layers/rpf/wizard
> > > cvs diff: Diffing src/gov/nasa/worldwind/pick
> > > cvs diff: Diffing src/gov/nasa/worldwind/render
> > > cvs diff: Diffing src/gov/nasa/worldwind/retrieve
> > > cvs diff: Diffing src/gov/nasa/worldwind/tracks
> > > cvs diff: Diffing src/gov/nasa/worldwind/util
> > > cvs diff: Diffing src/gov/nasa/worldwind/util/wizard
> > > cvs diff: Diffing src/gov/nasa/worldwind/view
> > > cvs diff: Diffing src/gov/nasa/worldwind/wms
> > > cvs diff: Diffing src/images
> > > [lihm@rbvm3 WorldWind]$ post-review
> >
> > > Error uploading diff
> >
> > > The generated diff file was empty. This usually means
> no files were
> > > modified in this change.
> >
> > > Try running with --output-diff and --debug for more
> information.
> >
> > > Your review request still exists, but the diff is not
> attached.
> > > [lihm@rbvm3 WorldWind]$ ls -l
> >
> > > --
> > > Want to help the Review Board project? Donate today at
> > >http://www.reviewboard.org/donate/
<http://www.reviewboard.org/donate/>
> <http://www.reviewboard.org/donate/
<http://www.reviewboard.org/donate/>>
> > > Happy user? Let us know
> athttp://www.reviewboard.org/users/
<http://www.reviewboard.org/users/>
> <http://www.reviewboard.org/users/
<http://www.reviewboard.org/users/>>
> > > -~----------~----~----~----~------~----~------~--~---
> > > To unsubscribe from this group, send email to
> > > reviewboard...@googlegroups.com
> > > For more options, visit this group at
> > >http://groups.google.com/group/reviewboard?hl=en
<http://groups.google.com/group/reviewboard?hl=en>
> <http://groups.google.com/group/reviewboard?hl=en
<http://groups.google.com/group/reviewboard?hl=en>>
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
<http://www.reviewboard.org/donate/>
> <http://www.reviewboard.org/donate/
<http://www.reviewboard.org/donate/>>
> Happy user? Let us know at http://www.reviewboard.org/users/
<http://www.reviewboard.org/users/>
> <http://www.reviewboard.org/users/
<http://www.reviewboard.org/users/>>
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
<http://groups.google.com/group/reviewboard?hl=en>
> <http://groups.google.com/group/reviewboard?hl=en
<http://groups.google.com/group/reviewboard?hl=en>>
>
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
<http://www.reviewboard.org/donate/>
> Happy user? Let us know at http://www.reviewboard.org/users/
<http://www.reviewboard.org/users/>
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to
> reviewboard...@googlegroups.com <javascript:>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
<http://groups.google.com/group/reviewboard?hl=en>
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it,
send
> an email to reviewboard...@googlegroups.com <javascript:>.
> For more options, visit https://groups.google.com/groups/opt_out
<https://groups.google.com/groups/opt_out>.
>
>
--
Christian Hammond - chi...@chipx86.com <javascript:>
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google
Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
