Re: Review Board 2.x and "hg postreview"

[Colin Caughie]

Following those instructions exactly I get an error message of "The specified diff file is empty", which is not surprising since file2.txt was never added to the repository. If I do "hg add file2.txt" before the first qnew on the other hand, "hg postreview" works fine and correctly shows Line2 being added to file2.txt. If it is still breaking for you even with the hg add, can you let me know what versions of mercurial, ReviewBoard and the reviewboard extension you're using? If you're using the latest versions and it still doesn't work, please send me the output of hg postreview --debug --apitrace Thanks, Colin On 6/4/2014 7:15 AM, Bruce Cran wrote: On Tue, Jun 3, 2014 at 8:33 AM, Colin Caughie <c.caug...@gmail.com> wrote: > It is something I'd like to get to the bottom of though so if you have any further information, > e.g. what's going on in the particular diffs and parent diffs that cause this issue, I'd be  glad to take a look at it. I've managed to recreate the problem such that 'rbt post' works and 'hg postreview' fails: first, on the remote server create a new repository with "hg init". Then, in Windows (with Python 2.7), run: hg clone <repo> rbtest01 cd rbtest01 echo Line1 > file1.txt hg add file1.txt hg commit -m "initial commit" hg push echo Line1 > file2.txt hg qnew first echo Line2 >> file2.txt hg qnew second hg postreview If you don't create file1.txt and try and create a review with an empty repo then 'rbt post' fails too, with: >>> 1 outgoing changesets between remote and base. >>> Running: hg parents --hidden -r 00d28ac9c6c6 --template {node|short} --config extensions.rbtoolsnormalize=C:\Python27\lib\site-packages\ rbtools-0.6-py2.7.egg\rbtools\helpers\hgext.py Traceback (most recent call last):   File "C:\Python27\Scripts\rbt-script.py", line 9, in <module>     load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()   File "C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\main.py", line 134, in main     command.run_from_argv([RB_MAIN, command_name] + args)   File "C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\__init__.py", line 422, in run_from_argv     exit_code = self.main(*args) or 0   File "C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\post.py", line 717, in main     revisions = self.get_revisions()   File "C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\commands\post.py", line 619, in get_revisions     self._revisions = self.tool.parse_revision_spec(self.cmd_args)   File "C:\Python27\lib\site-packages\rbtools-0.6-py2.7.egg\rbtools\clients\mercurial.py", line 267, in parse_revision_spec     '--template', '{node|short}']).split()[0] IndexError: list index out of range -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.