Hi Alexey,
Hmm, those are concerning issues. Never seen them before.
The interdiff code is complex and debugging this on our end would really
require full copies of the diffs and source code referenced.
Can you tell me the following:
1) How many files were modified in each diff?
2) How many files actually changed between the diffs?
3) Was the second diff made after pulling in upstream changes from your
source tree?
The file record issue is also pretty bad. Sounds like missing data. Maybe
just a bad query. Can you check your database for a diffviewer_filediff
table entry with that ID?
Christian
On Wednesday, December 3, 2014, Alexey Neyman <alexey.ney...@gmail.com>
wrote:
> Hi,
>
> Any comments on these two issues? At least, some pointers how to debug the
> second one (which does not give any traceback or any other valuable
> debugging information)?
>
> Regards,
> Alexey.
>
> On 11/20/2014 01:14 PM, Alexey Neyman wrote:
>
>> I've just seen a different problem with the interdiff: an attempt to
>> switch to the next page in the interdiff resulted in the following
>> traceback:
>>
>> Traceback (most recent call last):
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/diffviewer/views.py", line 94, in get
>> *args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.
>> egg/django/views/generic/base.py", line 154, in get
>> context = self.get_context_data(**kwargs)
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/reviews/views.py", line 832, in get_context_data
>> *args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/diffviewer/views.py", line 154, in get_context_data
>> page = paginator.page(page_num)
>> File
>> "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/core/paginator.py",
>> line 50, in page
>> number = self.validate_number(number)
>> File
>> "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/core/paginator.py",
>> line 43, in validate_number
>> raise EmptyPage('That page contains no results')
>> EmptyPage: That page contains no results
>>
>> Over the email, another traceback (which probably led to the one above)
>> was sent:
>>
>> File "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.
>> egg/django/core/handlers/base.py", line 112, in get_response
>> response = wrapped_callback(request, *callback_args,
>> **callback_kwargs)
>> File "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.
>> egg/django/views/decorators/cache.py", line 52, in _wrapped_view_func
>> response = view_func(request, *args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.
>> egg/django/views/decorators/vary.py", line 19, in inner_func
>> response = func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/resources.py", line 496, in __call__
>> request, method, view, api_format=api_format, *args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/resources.py", line 567, in call_method_view
>> return view(request, *args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 117, in _call
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/webapi/decorators.py", line 31, in _check
>> return webapi_login_required(view_func)(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 117, in _call
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 138, in _checklogin
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 117, in _call
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/webapi/decorators.py", line 110, in _check
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 117, in _call
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 287, in _validate
>> return view_func(*args, **new_kwargs)
>> File "/usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.
>> egg/djblets/webapi/decorators.py", line 117, in _call
>> return view_func(*args, **kwargs)
>> File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-
>> py2.6.egg/reviewboard/webapi/resources/diff_context.py", line 81, in get
>> self.item_result_key: context['diff_context'],
>> File
>> "/usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/http/response.py",
>> line 189, in __getitem__
>> return self._headers[header.lower()][1]
>> KeyError: u'diff_context'
>>
>> The URI that caused this:
>>
>> 'REQUEST_URI': '/api/review-requests/2157/diff-context/?revision=7&
>> interdiff-revision=9&page=3',
>>
>> Regards,
>> Alexey.
>>
>> On 11/20/2014 01:06 PM, Alexey Neyman wrote:
>>
>>> Any ideas what may be causing this error? What additional debug
>>> information can be obtained - the message quoted below is not very much
>>> informative as to what went wrong...
>>>
>>> Regards,
>>> Alexey.
>>>
>>> On 11/05/2014 06:21 PM, Alexey Neyman wrote:
>>>
>>>> Hi,
>>>>
>>>> On certain review requests, trying to display the diff between
>>>> revisions of the patch results in an error message as follows:
>>>>
>>>> [[[
>>>> There was an error displaying this diff.
>>>> Internal error. Unable to locate file record for filediff 130782
>>>> This may be a bug in the software, a temporary outage, or an issue with
>>>> the format of your diff.
>>>> Please try again, and if you still have trouble, contact support.
>>>> ]]]
>>>>
>>>> Using 2.0.11, Subversion backend.
>>>>
>>>> Regards,
>>>> Alexey.
>>>>
>>>
>>>
>>
> --
> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
> ---
> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
> ---
> Happy user? Let us know at http://www.reviewboard.org/users/
> --- You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
--
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
