Hi,
The ExtraDataMixin exists but none of the built-in code uses it, and I
think it's broken. We need to rethink it a bit anyway in light of the new
JSON Patch and JSON Merge Patch support that was added in 3.0.
For now, I think this will get you up and running:
const extraData = this.model.get('extraData');
extraData['veto'] = 1;
saveFunc.call(this.model, {
attrs: ['public', 'shipIt', 'forceTextType', 'includeTextTypes',
'publishToOwnerOnly', 'extraData.veto'],
});
On Thu, Dec 21, 2017 at 11:57 AM Christian Hammond <christ...@beanbaginc.com>
wrote:
> I haven’t been able to fix it yet. With the holidays coming up, things
> have been busy, and we’ve had a couple higher-priority bugs taking our
> time. I’ll make my way back to this soon though.
>
> Christian
>
>
> On Tue, Dec 19, 2017 at 18:27 Xy Sui <oswi...@gmail.com> wrote:
>
>> Hi Christian,
>>
>> Any progress on this topic?
>>
>> BR
>> oswicer
>>
>>
>> On Thursday, December 14, 2017 at 7:00:10 PM UTC+8, Xy Sui wrote:
>>
>>> Hi,
>>>
>>> I'm getting desperate after hours' searching/trying... One of our
>>> extensions doesn't work now in RVB3.0 because previous setExtraData method
>>> doesn't work anymore for review model.
>>>
>>> In my implementation, I wrote one RB.ReviewDialogHook javascript hook
>>> with one customized view. And I would like to save some data in model
>>> Review's extraData field. I noticed model Review does have "setExtraData"
>>> method, but it's not working...
>>>
>>> And it looks like the extension rbstopwatch also saves data in
>>> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't
>>> find one working example either.
>>>
>>> Could anybody help? Or anybody has one working example for extra_data
>>> setting in javascript?
>>>
>>> Thanks.
>>>
>>> BR
>>> oswicer
>>>
>>>
>>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
