----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44816/#review123562 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On March 15, 2016, 12:21 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44816/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 12:21 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15415 > https://issues.apache.org/jira/browse/AMBARI-15415 > > > Repository: ambari > > > Description > ------- > > AMBARI-15293, changed the metric names for rpc and rpcdetailed metrics for NN > based on the port configuration for client / datanode / healthcheck rpc > > We need a fix this by cloning the alert definition that we have into 2 > different alerts for Client / DN ports. > > *Note*: By default client and DN RPC ports are the same 8020 and for this > case DN rpc alert should be a NOOP. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 611cb92 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json > 2a6229c > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > f6a9a56 > > Diff: https://reviews.apache.org/r/44816/diff/ > > > Testing > ------- > > Manually verified, python unit tests passed. > > > Thanks, > > Sid Wagle > >
