----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45302/#review125623 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On March 27, 2016, 4:03 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45302/ > ----------------------------------------------------------- > > (Updated March 27, 2016, 4:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-15564 > https://issues.apache.org/jira/browse/AMBARI-15564 > > > Repository: ambari > > > Description > ------- > > Add a way to supply the repo_version to use when creating a cluster. This > will result in a new cluster_version record BEFORE any hosts have been added > to the cluster. This work effectively unblocks the UI to be able to supply a > version when creating the cluster. Including Blueprints. > > What this patch does NOT do (other patches will address this): > - Refactor how RepositoryVersionState is computed for installs to work just > like upgrades. > - Create a cluster using a Version Definition File (VDF) url, pull down the > file, and create the repo_version record. To use this feature, the > repo_version must be created BEFORE supplying the version with the cluster. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 32da5e8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 23d43aa > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java > 5c7548c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > f7d359c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > a1740fb > > ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java > cc8cfdb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > ddd07f9 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > 119205a > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 8d6fec1 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 87225ad > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > c317162 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > ec38f22 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 57cbebc > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > 1613d11 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java > 6e7c975 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 91f4993 > > Diff: https://reviews.apache.org/r/45302/diff/ > > > Testing > ------- > > Manual. Automated: > > Tests run: 3992, Failures: 0, Errors: 0, Skipped: 33 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:21.378s > [INFO] Finished at: Thu Mar 24 15:59:06 EDT 2016 > [INFO] Final Memory: 33M/610M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
