> On March 29, 2016, 4:16 p.m., Alexandr Antonenko wrote: > > Ship It!
Tested manually, good UX improvement. - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45405/#review125893 ----------------------------------------------------------- On March 28, 2016, 11:01 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45405/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 11:01 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg > Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15610 > https://issues.apache.org/jira/browse/AMBARI-15610 > > > Repository: ambari > > > Description > ------- > > On "Add Service Wizard Assign Masters" page, invalid host name (when there > are more than 25 hosts, we use input field instead of select list) does not > disable the "next" button. After clicking the next button, wizard navigates > to "Assign Slaves and Clients" page and the (wrong) input of the host name > gets ignored without notification. > > > Diffs > ----- > > ambari-web/app/messages.js 4fa6ba5 > ambari-web/app/mixins/wizard/assign_master_components.js 93ecac3 > ambari-web/app/views/common/assign_master_components_view.js bfc674d > > Diff: https://reviews.apache.org/r/45405/diff/ > > > Testing > ------- > > Local ambari-web test passed. > 24689 tests complete (21 seconds) > 145 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
