----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/#review125906 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py (line 105) <https://reviews.apache.org/r/45432/#comment188810> using those sudo's used outside the resources may cause some problems in future, since not designed to be so. Please use Directory(curl_krb_cache_path, mode=0777) ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py (line 294) <https://reviews.apache.org/r/45432/#comment188811> Why do we use ignore_failures here. Masking errors in a bad practice, which leads to hard to takle bugs. Also it won't fail if dir doesn't exist. - Andrew Onischuk On March 29, 2016, 3:57 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45432/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 3:57 p.m.) > > > Review request for Ambari, Andrew Onischuk and Jonathan Hurley. > > > Bugs: AMBARI-15616 > https://issues.apache.org/jira/browse/AMBARI-15616 > > > Repository: ambari > > > Description > ------- > > 1)Deploy cluster > 2)Enable/Disable security (MIT) > 3)Enable security (MIT) > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py > 21cdd09 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > 013aabc > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > b72c4bf > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > b3b7940 > > Diff: https://reviews.apache.org/r/45432/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >