-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45579/
-----------------------------------------------------------

(Updated ápr. 1, 2016, 12:07 du)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sebastian Toader.


Bugs: AMBARI-15665
    https://issues.apache.org/jira/browse/AMBARI-15665


Repository: ambari


Description
-------

Due to a programming error, username was accuired from directly the Spring 
Security Context. When the ldap authentication was used, type casting failed. 
Now username is retrieved by using the AuthorizationHelper class and setting 
username is moved to AbstractUserAuditEvent.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractUserAuditEvent.java
 a968a64 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertGroupEventCreator.java
 103fd4d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertTargetEventCreator.java
 29a241e 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintEventCreator.java
 bdd6dbe 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintExportEventCreator.java
 1416021 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ComponentEventCreator.java
 8034d24 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java
 7e58893 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/CredentialEventCreator.java
 3b1f462 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/DefaultEventCreator.java
 d0f57f2 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/GroupEventCreator.java
 d926d94 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
 910280d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/MemberEventCreator.java
 a3c3164 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java
 bdc7b59 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryEventCreator.java
 fe6f8cc 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java
 7c9c731 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 fd13973 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceConfigDownloadEventCreator.java
 681cfb8 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceEventCreator.java
 2e2b91d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UnauthorizedEventCreator.java
 d53aa68 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeEventCreator.java
 b8a6873 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeItemEventCreator.java
 9f83172 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java
 2b4e5c1 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ViewInstanceEventCreator.java
 611b1ea 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ViewPrivilegeEventCreator.java
 18b860a 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
 5c23059 

Diff: https://reviews.apache.org/r/45579/diff/


Testing
-------

Auditlog and AuthorizationHelper tests should cover the test cases of the 
current change.


Thanks,

Daniel Gergely

Reply via email to