----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/#review126795 -----------------------------------------------------------
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js (line 19) <https://reviews.apache.org/r/44704/#comment189884> Looks like you can delete this file. Even if the file name is queueMappingParser.js, this is same as queueMappingInterpreter.js. Also correct th require. contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 142) <https://reviews.apache.org/r/44704/#comment189877> We souldnt have commented code. The line can be removed if not required. contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 229) <https://reviews.apache.org/r/44704/#comment189878> All debug logs must be removed. contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 241) <https://reviews.apache.org/r/44704/#comment189879> All debug logs must be removed. contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 275) <https://reviews.apache.org/r/44704/#comment189880> Again remove comments. contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less (line 887) <https://reviews.apache.org/r/44704/#comment189885> Intentation contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs (line 28) <https://reviews.apache.org/r/44704/#comment189888> Whay are we having an anchor tags inside link-to? And what is the purpose fo href="view.href". - Sreenath Somarajapuram On March 11, 2016, 10:41 a.m., Akhil PB wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44704/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 10:41 a.m.) > > > Review request for Ambari and Sreenath Somarajapuram. > > > Bugs: AMBARI-15384 > https://issues.apache.org/jira/browse/AMBARI-15384 > > > Repository: ambari > > > Description > ------- > > Revamping the old capsched UI into new better one > > > Diffs > ----- > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > ac679b7 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js > 16b7d0a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 05bb64c > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a2d50b9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > be79229 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 25e2aa9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/44704/diff/ > > > Testing > ------- > > Manual unit testing > > > Thanks, > > Akhil PB > >