> On 4月 6, 2016, 9:05 a.m., Akira Ajisaka wrote: > > Can someone commit it? > > Dmytro Sen wrote: > Committed to trunk. > > Thanks Akira.
Thank you, Dmytro and Aravindan! - Akira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45374/#review127304 ----------------------------------------------------------- On 3月 30, 2016, 2:02 a.m., Akira Ajisaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45374/ > ----------------------------------------------------------- > > (Updated 3月 30, 2016, 2:02 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle. > > > Bugs: AMBARI-15588 > https://issues.apache.org/jira/browse/AMBARI-15588 > > > Repository: ambari > > > Description > ------- > > If we want to rotate ambari-metrics-collector.out by logrotate (using > copytruncate option), we need to use ">>" instead of ">" not to keep the file > offset to write. If the offset is kept, null characters are padded in the new > file. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor > 7464c55 > > Diff: https://reviews.apache.org/r/45374/diff/ > > > Testing > ------- > > Manually tested the patch and verified that the .out is rotated collectly. > > > Thanks, > > Akira Ajisaka > >
