----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/#review127582 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On April 7, 2016, 1:47 p.m., Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45538/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 1:47 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader. > > > Bugs: AMBARI-15646 > https://issues.apache.org/jira/browse/AMBARI-15646 > > > Repository: ambari > > > Description > ------- > > ThreadLocal: > InitialValue() method is used when initializing the ThreadLocal member > variable. > > Multibinder: > The same logic is used for binding multiple classes from a package > "automatically" as in org.apache.ambari.server.cleanup.CleanupModule. > > Creator properties: > Property retrieval from responses now grouped into an abstract baseclass. It > can get properties from namedPropertySets and propertySets. > > Auditlog enabling: > Added checks to more places in the code to skip auditlog related object > creation if auditlog is disabled. > > Cache: > The previously existing 3 variables now groupped into a single data structure > to act as a cache. Every request has a RequestDetails object, which contains > the last status of the request and a map for tasks. A task has a key that is > composed of a component name and a host name, the value is the previous > status of the task. > By using this structure, tasks for components can easily be removed and if > the RequestDetails has no task, the request itself can also be removed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 79d3470 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 2e5b920 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LogoutService.java > 3b449ca > > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java > 1cfb740 > > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java > b20714b > > ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java > 319d772 > > ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java > eaea058 > > ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/MembershipChangeRequestAuditEvent.java > 040934e > > ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/StartOperationRequestAuditEvent.java > 66e37b8 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditEventCreator.java > ccb39de > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditLoggerImpl.java > 56efd18 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertGroupEventCreator.java > 366dfff > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertTargetEventCreator.java > abad559 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintEventCreator.java > a91a9c1 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintExportEventCreator.java > 85379d8 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ComponentEventCreator.java > 870a797 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java > b671138 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/CredentialEventCreator.java > 0647553 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/DefaultEventCreator.java > feda291 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/GroupEventCreator.java > 30fef98 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > 7bc0133 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/MemberEventCreator.java > f0158f5 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java > 11168f1 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RecommendationIgnoreEventCreator.java > 6b7bb2b > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryEventCreator.java > ca3bac4 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java > 3f5e2d0 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreator.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java > 3a33114 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceConfigDownloadEventCreator.java > 0999010 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceEventCreator.java > 65d94f9 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UnauthorizedEventCreator.java > db3c934 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeEventCreator.java > f9f4152 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeItemEventCreator.java > 1869909 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java > 89f0755 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ValidationIgnoreEventCreator.java > 081f3d3 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ViewInstanceEventCreator.java > a9a3fcd > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ViewPrivilegeEventCreator.java > d2d7bd9 > > ambari-server/src/main/java/org/apache/ambari/server/cleanup/ClasspathScannerUtils.java > 4c12a62 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java > 36469c1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java > 992d33f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java > 1678931 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 3c33a23 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java > 04e5f67 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > a45b1ac > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 0384f6c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java > fee1826 > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java > 9c2b42b > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilter.java > 5663ed2 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > 96d6131 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PermissionHelper.java > ecf2d7a > > ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java > 0b84568 > > ambari-server/src/test/java/org/apache/ambari/server/audit/ActionDBAAccessorAuditlogTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/AbstractBaseCreator.java > 02ecb00 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/RequestAuditLogModule.java > 52ad44c > > ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilterTest.java > f6a885d > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > 3dd6b0a > > Diff: https://reviews.apache.org/r/45538/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gergely > >