----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/ -----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Oliver Szabo, and Sandor Magyari. Bugs: AMBARI-13240 https://issues.apache.org/jira/browse/AMBARI-13240 Repository: ambari Description ------- Because multiple KDCs may exist for an installation (failover, high availability, etc...), Ambari should allow a user to specify multiple KDC hosts to be set while enabling Kerberos and updating the Kerberos service's configuration. This should be done by allowing {{kerberos-env/kdc_host}} to accept a (comma-)delimited list of hosts and then parsing that list properly when building the krb5.conf file where each {{kdc_host}} item generates an entry in the relevant realm block. For example: # kerberos-env ``` { ... "kdc_hosts" : "kdc1.example.com, kdc2.example.com" ... } ``` # krb5.conf ``` [realms] EXAMPLE.COM = { ... kdc = kdc1.example.com kdc = kdc2.example.com ... } ``` Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/rest/KdcServerReachabilityCheck.java 827b187 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 1ba138b ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 139fd7a ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 65dad79 ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 69b9a43 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml bb880e2 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml 6780d2e ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py 200a212 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 cc6f63a ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java e8a2e35 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 411f966 ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandlerTest.java f877e85 ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 5c882ba ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java 616d37f ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java a583d39 ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py a11d596 ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 181c16d ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json c1ca3aa ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 7df0daf ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json f60fa8f ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json a321dfb ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json db8e60b ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 8ecb91b ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json b82c0ee ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/KERBEROS.json b34c7b4 ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 7f77c38 ambari-web/app/controllers/main/admin/kerberos/step5_controller.js 38150c8 ambari-web/app/controllers/main/service/info/configs.js 8943d7c ambari-web/app/data/HDP2/site_properties.js 3586b0f ambari-web/app/messages.js 2d6ec67 ambari-web/app/mixins/common/configs/toggle_isrequired.js cc2cc35 ambari-web/app/models/configs/objects/service_config_property.js e7eaebd ambari-web/app/views/common/controls_view.js 2514d9d ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js beacc63 ambari-web/test/mixins/common/configs/toggle_isrequired_test.js 4672ae6 ambari-web/test/views/common/controls_view_test.js dca7911 Diff: https://reviews.apache.org/r/45914/diff/ Testing ------- manually tested new cluster and upgraded cluster # Jenkins test results: PENDING Thanks, Robert Levas