> On April 8, 2016, 3:04 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > <https://reviews.apache.org/r/45930/diff/1/?file=1337196#file1337196line186> > > > > Should we initialize if Storm/Kafka are not deployed? What happens when > > Add Service is called later. > > Dmytro Sen wrote: > I handle it inside initializeStromAnsKafkaWidgets() > > if ("STORM".equals(service.getName()) || > "KAFKA".equals(service.getName())) { > controller.initializeWidgetsAndLayouts(cluster, service); > } > > Dmytro Sen wrote: > and only for deployed services > > Map<String, Service> serviceMap = cluster.getServices();
Ha! not sure how I missed that. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127802 ----------------------------------------------------------- On April 8, 2016, 3:04 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45930/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 3:04 p.m.) > > > Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-15759 > https://issues.apache.org/jira/browse/AMBARI-15759 > > > Repository: ambari > > > Description > ------- > > 1. Running Ambari 2.2.1.0 > 2. Upgraded to Amabri 2.2.1.1 > 3. Storm widgets are not showing on Services > Storm > Summary > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > 77b8b45 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 5f07e56 > > Diff: https://reviews.apache.org/r/45930/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
