> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 137 > > <https://reviews.apache.org/r/45972/diff/2/?file=1338575#file1338575line137> > > > > why the check for params.current_version to be not None?
Fixed. Doesn't make sense there. > On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 184 > > <https://reviews.apache.org/r/45972/diff/2/?file=1338575#file1338575line184> > > > > Do not hard code path to folder .slider/keytabs/hive - hive. The > > setup_security() method is using {params.hive_user}. Use the same here as > > well. Done. > On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 504 > > <https://reviews.apache.org/r/45972/diff/2/?file=1338576#file1338576line504> > > > > Remove the variable llap_local_dir Removed. Not required till we decide on creating LLAP related work dirs. - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/#review128067 ----------------------------------------------------------- On April 11, 2016, 5:03 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45972/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 5:03 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, > and Sumit Mohanty. > > > Bugs: AMBARI-15785 > https://issues.apache.org/jira/browse/AMBARI-15785 > > > Repository: ambari > > > Description > ------- > > HiveServerInteractive. Kerberos Support. > > - Needs to have hive keytabs on all nodemanagers. > - Hive Server Interactive needs same keytabs as HiveServer and Metastore. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 055296b > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > c7d57c0 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > 5830a52 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > a3009ee > > Diff: https://reviews.apache.org/r/45972/diff/ > > > Testing > ------- > > - Partially done. > - Python UT : PASSES. > > > Thanks, > > Swapan Shridhar > >
