----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46310/#review129279 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py (line 309) <https://reviews.apache.org/r/46310/#comment192752> We already have a helper method Directory() - creating a wrapper around it is reducing readability - makes it difficult to write the unit test with mocks. ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 85) <https://reviews.apache.org/r/46310/#comment192754> The for loop is not needed here. ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 497) <https://reviews.apache.org/r/46310/#comment192755> The symlink works as a valid dest. - Sumit Mohanty On April 18, 2016, 2:11 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46310/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 2:11 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Swapan > Shridhar. > > > Bugs: AMBARI-15937 > https://issues.apache.org/jira/browse/AMBARI-15937 > > > Repository: ambari > > > Description > ------- > > Along with the changes, there are some clean-up and addition of basic unit > tests. Some more comments in the diff. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 7d913e5 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > 9d05d37 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 03fd40c > ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/46310/diff/ > > > Testing > ------- > > Ran unit tests manually, and tested by applying patch. > > > Thanks, > > Sumit Mohanty > >
