> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java, > > line 4900 > > <https://reviews.apache.org/r/46327/diff/1/?file=1348456#file1348456line4900> > > > > I'm not certain that the tests using the public property should be > > modified. I'd recommend adding new unit tests to verify that the internal > > property being added here is handled properly.
We rely on "dfs.internal.nameservices" in 2.4.0, "dfs.nameservices" might contain name services, not managed by Ambari. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46327/#review129331 ----------------------------------------------------------- On Апрель 18, 2016, 1:39 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46327/ > ----------------------------------------------------------- > > (Updated Апрель 18, 2016, 1:39 п.п.) > > > Review request for Ambari, John Speidel and Sumit Mohanty. > > > Bugs: AMBARI-15791 > https://issues.apache.org/jira/browse/AMBARI-15791 > > > Repository: ambari > > > Description > ------- > > Blueprint config processing engine should automatically populate > dfs.internal.nameservices when it is deploying HA clusters. The work-around > till then is to explicitly add the property when submitting the blueprint. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1433a1b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 834953b > > Diff: https://reviews.apache.org/r/46327/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
