----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129420 -----------------------------------------------------------
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java (line 103) <https://reviews.apache.org/r/46152/#comment192845> I just added a return value here if the code executed successfully, the real assert here is the verify, that checks how many times the "request" called. altough the test method name is not right, that is the CollectionDoesNotExist case not the CollectionExists - Oliver Szabo On April 18, 2016, 4:47 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46152/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 4:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert > Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-15865 > https://issues.apache.org/jira/browse/AMBARI-15865 > > > Repository: ambari > > > Description > ------- > > Create a small ambari solr client (and rpm/deb), for logsearch solr. > The goal is the create a client which can be used for another services to > access zookeeper/solr and create their own collections in logsearch solr. > (e.g. for ATLAS or RANGER) > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java > PRE-CREATION > ambari-logsearch/pom.xml 475de9f > > Diff: https://reviews.apache.org/r/46152/diff/ > > > Testing > ------- > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - > in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest > > > Thanks, > > Oliver Szabo > >
